adds more tests to get to 97% overall coverage

pgmax/fg/groups.py

@@ -206,7 +206,7 @@ def get_vars_to_evidence(
 
         Args:
             evidence: A mapping or a sequence of evidences.
-                The type of evidence should match that of self.variable_group_container
+                The type of evidence should match that of self.variable_group_container.
 
         Returns:
             a dictionary mapping all possible variables to the corresponding evidence
@@ -337,7 +337,7 @@ def get_vars_to_evidence(
 
             if evidence[key].shape != (self.variable_size,):
                 raise ValueError(
-                    f"Variable {key} expect an evidence array of shape "
+                    f"Variable {key} expects an evidence array of shape "
                     f"({(self.variable_size,)})."
                     f"Got {evidence[key].shape}."
                 )

tests/fg/test_groups.py

@@ -1,3 +1,4 @@
+import numpy as np
 import pytest
 
 from pgmax.fg import groups
@@ -21,3 +22,34 @@ def test_composite_vargroup_valueerror():
     with pytest.raises(ValueError) as verror:
         comp_var_group[tuple([0])]
     assert "The key needs" in str(verror.value)
+
+
+def test_composite_vargroup_evidence():
+    v_group1 = groups.GenericVariableGroup(3, tuple([0, 1, 2]))
+    v_group2 = groups.GenericVariableGroup(3, tuple([0, 1, 2]))
+    comp_var_group = groups.CompositeVariableGroup(tuple([v_group1, v_group2]))
+    assert (
+        len(
+            comp_var_group.get_vars_to_evidence(
+                [{0: np.zeros(3)}, {0: np.zeros(3)}]
+            ).keys()
+        )
+        == 2
+    )
+
+
+def test_ndvararray_evidence_error():
+    v_group = groups.NDVariableArray(3, (2, 2))
+    with pytest.raises(ValueError) as verror:
+        v_group.get_vars_to_evidence(np.zeros((1, 1)))
+    assert "Input evidence" in str(verror.value)
+
+
+def test_generic_evidence_errors():
+    v_group = groups.GenericVariableGroup(3, tuple([0]))
+    with pytest.raises(ValueError) as verror:
+        v_group.get_vars_to_evidence({1: np.zeros((1, 1))})
+    assert "The evidence is referring" in str(verror.value)
+    with pytest.raises(ValueError) as verror:
+        v_group.get_vars_to_evidence({0: np.zeros((1, 1))})
+    assert "expects an evidence array" in str(verror.value)