Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataclass pytree registration bug #34

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Fix dataclass pytree registration bug #34

merged 2 commits into from
Jul 30, 2021

Conversation

StannisZhou
Copy link
Contributor

@StannisZhou StannisZhou commented Jul 30, 2021 •
edited
Loading

Addresses #20

Now we can regard EnumerationWiring as a pytree and do things like jax.device_put or jax.tree_util.tree_map, etc..

NishanthJKumar
NishanthJKumar approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@NishanthJKumar NishanthJKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for figuring this out!

@NishanthJKumar NishanthJKumar linked an issue Jul 30, 2021 that may be closed by this pull request
Bug in pytree registration code for dataclass #20
Closed
@NishanthJKumar NishanthJKumar merged commit 40efc27 into vicariousinc:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NishanthJKumar NishanthJKumar NishanthJKumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in pytree registration code for dataclass
2 participants
@StannisZhou @NishanthJKumar