Make BP closer to jax optimizer #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StannisZhou
reviewed
Apr 7, 2022
|
Also if you want the corresponding issue to be automatically linked I think you need to say resolves #124 |
|
@StannisZhou all your comments have been adressed |
StannisZhou
approved these changes
Apr 8, 2022
| @@ -1002,7 +1044,14 @@ def get_beliefs(bp_arrays: BPArrays) -> Any: | |||
| ) | |||
| return beliefs | |||
|
|
|||
| return run_bp, get_bp_state, get_beliefs | |||
| bp_container = BPContainer( | |||
| init=functools.partial(update, None), | |||
There was a problem hiding this comment.
Does this mean init can only take keyword arguments? If so mention that in the documentation for init in BeliefPropagation
There was a problem hiding this comment.
this restriction does not apply, why do you think it would?
antoine-dedieu
force-pushed
the
run_bp_changes
branch
from
b539026
to
35d47d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 950 967 +17
=========================================
+ Hits 950 967 +17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #124
We make
graph.BPcloser to JAX optimizers https://jax.readthedocs.io/en/latest/jax.example_libraries.optimizers.html