Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using PGMax to solve the PMP 2D blind deconvolution exp #127

Merged
merged 6 commits into from
Mar 25, 2022

Conversation

antoine-dedieu
Copy link
Contributor

@antoine-dedieu antoine-dedieu commented Mar 24, 2022

We use PGMax to solve the binary deconvolution experiment presented in the Section 5.6 of the perturb-and-max-product (https://proceedings.neurips.cc/paper/2021/hash/07b1c04a30f798b5506c1ec5acfb9031-Abstract.html) Neurips 2021 paper.

The example pmp_convor.py computes several samples from the posterior of the model via PMP

Screen Shot 2022-03-23 at 5 22 39 PM

This addresses #112

@antoine-dedieu antoine-dedieu changed the title Adding PMP convor exp Implementing the PMP convor exp with PGMax Mar 24, 2022
@antoine-dedieu antoine-dedieu changed the title Implementing the PMP convor exp with PGMax Implementing the PMP 2D blind deconvolution exp with PGMax Mar 24, 2022
@antoine-dedieu antoine-dedieu changed the title Implementing the PMP 2D blind deconvolution exp with PGMax Using PGMax to solve the PMP 2D blind deconvolution exp Mar 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #127 (b416f00) into master (ad52b65) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          854       854           
=========================================
  Hits           854       854           
Impacted Files Coverage Δ
pgmax/factors/logical.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad52b65...b416f00. Read the comment docs.

@StannisZhou StannisZhou self-requested a review March 24, 2022 00:30
Copy link
Contributor

@StannisZhou StannisZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments (mostly on making the notebook more easily understandable).

After you are done, could you also create a colab notebook out of it, and add it to the README page, similar to what we already have?

examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
examples/pmp_convor.py Outdated Show resolved Hide resolved
@StannisZhou
Copy link
Contributor

Also I believe this resolves #112 not issue #11

@StannisZhou StannisZhou linked an issue Mar 24, 2022 that may be closed by this pull request
Copy link
Contributor

@StannisZhou StannisZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments. Also don't forget to create the colab and add the link to README

examples/pmp_binary_deconvolution.py Outdated Show resolved Hide resolved
examples/pmp_binary_deconvolution.py Outdated Show resolved Hide resolved
examples/pmp_binary_deconvolution.py Outdated Show resolved Hide resolved
examples/pmp_binary_deconvolution.py Outdated Show resolved Hide resolved
examples/pmp_binary_deconvolution.py Outdated Show resolved Hide resolved
@antoine-dedieu antoine-dedieu merged commit 81c4f20 into vicariousinc:master Mar 25, 2022
@antoine-dedieu antoine-dedieu deleted the pmp_convor_exp branch March 25, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for 2d blind deconvolution example
3 participants