Vendor ipaddress and email.utils; renorm ipv4 and ipv6 types based on updated ipaddress corrections (SYN-5490, SYN-7937)

[vEpiphyte]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 95.39267% with 88 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (8fe9226) to head (752e875).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
synapse/vendor/cpython/lib/email/utils.py	83.58%	33 Missing ⚠️
synapse/vendor/cpython/lib/email/_parseaddr.py	91.01%	31 Missing ⚠️
synapse/vendor/cpython/lib/ipaddress.py	98.43%	15 Missing ⚠️
...ynapse/vendor/cpython/lib/test/support/__init__.py	87.69%	8 Missing ⚠️
...e/vendor/cpython/lib/test/test_email/test_utils.py	99.10%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #3902     +/-   ##
=========================================
  Coverage   96.31%   96.32%             
=========================================
  Files         245      252      +7     
  Lines       54822    58329   +3507     
=========================================
+ Hits        52802    56185   +3383     
- Misses       2020     2144    +124     

Flag	Coverage Δ
linux	96.32% <95.39%> (+0.08%)	⬆️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MichaelSquires]

Should we be counting test coverage in vendored code?

[vEpiphyte]

@MichaelSquires Let me add their unit tests and make them subclass the VendorTest helper 👍

[Cisphyx]

Looks like we're picking up the vendor test files in coverage, should we add synapse/vendor/**/test_*.py to the omit in .coveragerc ?

[vEpiphyte]

@Cisphyx I removed some of the tests that we'll never run ( osx 10.7 tests... ) and their associated helpers. I actually don't mind having coverage reporting for those vendored tests as it does give us insight into what behaviors the original authors have / had from their original files.

[vEpiphyte]

Related cpython issue python/cpython#113171