Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add revision history limit #136

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Conversation

pohldk
Copy link
Contributor

@pohldk pohldk commented Sep 18, 2023

I would like to be able to change the default revisionHistoryLimit which is by default 10 :
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/

I don't need to be able to roll back 10 times, would much rather have the performance.
This is of course different from user to user, which is why I want to have it as a variable.

From source:
image

@juanpicado
Copy link
Member

Could you give more context what's revisionHistoryLimit about?

@pohldk
Copy link
Contributor Author

pohldk commented Nov 29, 2023

Could you give more context what's revisionHistoryLimit about?

Of course, this was something that annoyed me when I needed to deploy this, and created the pullrequest to fix it. Never got to the point where I added the context

@ardelato
Copy link

ardelato commented Jan 5, 2024

Is there any update to this?

We're working on minimizing the number of ReplicaSets in our cluster, but currently, Kubernetes lacks a straightforward method to establish a new default limit. This means manually specifying the spec.revisionHistoryLimit for each service we deploy. However, the Helm chart for Verdaccio doesn't offer an option to adjust this field, which leaves us with no choice but to directly deploy the manifests or devise an intricate method to modify all deployment manifests in our cluster. Having the ability to modify the spec.revisionHistoryLimit value through the Helm chart would be very useful.

@juanpicado
Copy link
Member

I will check on this

@juanpicado juanpicado merged commit 8ad5c83 into verdaccio:master Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants