fix: Ensure ergonomic handling of non-page in `./pages/` #7955

nataliemarleny · 2019-07-14T13:12:46Z

This PR adds a sufficiently informative error when a non-page is added to the ./pages directory when target: severless

8e8bb0e

Update autoExport failed to automatic static optimization failed as discussed in issue comments: see Ensure ergonomic handling of non-page in ./pages/ #7836 (comment)

cb21fe7

Update test for autoExport error message to reflect rename to automatic static optimization

73203ec

Update the outputted error message for handling a non-page in ./pages when target: serverless'

097d5e8

Add test for changes made in 73203ec

Handling a non-page in `./pages` when `target: serverless'`:

Error Message after fix:

$ next build
Creating an optimized production build ...

Failed to compile.

> Build error occurred
Error: webpack build failed: found page without a React Component as default export in pages/abc.tsx

See https://err.sh/zeit/next.js page-without-valid-component for more info.
    at build (/Users/nataliemarleny/nextjs-sandbox/node_modules/next/dist/build/index.js:14:418)
    at process._tickCallback (internal/process/next_tick.js:68:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Error Message prior to fix:

$ next build
Creating an optimized production build ...

> Using external babel configuration
> Location: "/Users/timneutkens/projects/something/.babelrc"
Failed to compile.

./node_modules/next/dist/build/webpack/loaders/next-serverless-loader.js?page=%2Fhome%2Fstyles&absolutePagePath=private-next-pages%2Fhome%2Fstyles.js&absoluteAppPath=next%2Fdist%2Fpages%2F_app&absoluteDocumentPath=private-next-pages%2F_document.js&absoluteErrorPath=next%2Fdist%2Fpages%2F_error&distDir=private-dot-next&assetPrefix=&generateEtags=true&ampBindInitData=false&canonicalBase=&dynamicBuildId=false
Attempted import error: 'private-next-pages/home/styles.js' does not contain a default export (imported as 'ComponentInfo').

> Build error occurred
Error: > webpack config.resolve.alias was incorrectly overriden. https://err.sh/zeit/next.js/invalid-resolve-alias
    at build (/Users/timneutkens/projects/something/node_modules/next/dist/build/index.js:6:235)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)
error Command failed with exit code 1.

fixes: #7836

packages/next/build/index.ts

github-actions · 2019-07-14T18:49:32Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.3s	14.1s	-189ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	⚠️ +1 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	-1 B
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	224 B	⚠️ +2 B
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	300 B	-1 B
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	15.1s	15.2s	⚠️ +142ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.7 kB	86.7 kB	⚠️ +1 B
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	328 kB	328 kB	✓
Serverless `pages/_error` gzip Size	84 kB	84 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	329 kB	329 kB	✓
Serverless `pages/routerDirect` gzip Size	84.3 kB	84.3 kB	-1 B
Serverless `pages/withRouter` Size	329 kB	329 kB	✓
Serverless `pages/withRouter` gzip Size	84.3 kB	84.3 kB	✓
Build Dir Size	1.94 MB	1.94 MB	✓

github-actions · 2019-07-14T20:32:01Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	12.9s	12.5s	-453ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	13.6s	13s	-573ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.7 kB	86.7 kB	⚠️ +1 B
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	328 kB	328 kB	✓
Serverless `pages/_error` gzip Size	84 kB	84 kB	✓
Serverless `pages/routerDirect` Size	329 kB	329 kB	✓
Serverless `pages/routerDirect` gzip Size	84.3 kB	84.3 kB	✓
Serverless `pages/withRouter` Size	329 kB	329 kB	✓
Serverless `pages/withRouter` gzip Size	84.3 kB	84.3 kB	✓
Build Dir Size	1.94 MB	1.94 MB	✓

github-actions · 2019-07-14T21:26:52Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.5s	14.1s	-310ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.5s	15s	⚠️ +410ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	-1 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	⚠️ +1 B
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	224 B	222 B	-2 B
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	300 B	301 B	⚠️ +1 B
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.7 kB	86.7 kB	-1 B
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	328 kB	328 kB	✓
Serverless `pages/_error` gzip Size	84 kB	84 kB	-1 B
Serverless `pages/routerDirect` Size	329 kB	329 kB	✓
Serverless `pages/routerDirect` gzip Size	84.3 kB	84.3 kB	✓
Serverless `pages/withRouter` Size	329 kB	329 kB	✓
Serverless `pages/withRouter` gzip Size	84.3 kB	84.3 kB	-1 B
Build Dir Size	1.94 MB	1.94 MB	✓

- Update other Next error message for consistency

Co-Authored-By: Lukáš Huvar <[email protected]>

- Also reflect new wording of error message for readability

- When target: severless

github-actions · 2019-07-15T14:38:42Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.3s	13.6s	-663ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.9s	14.7s	-169ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.7 kB	86.7 kB	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	328 kB	328 kB	✓
Serverless `pages/_error` gzip Size	84 kB	84 kB	✓
Serverless `pages/routerDirect` Size	329 kB	329 kB	✓
Serverless `pages/routerDirect` gzip Size	84.3 kB	84.3 kB	✓
Serverless `pages/withRouter` Size	329 kB	329 kB	✓
Serverless `pages/withRouter` gzip Size	84.3 kB	84.3 kB	✓
Build Dir Size	1.94 MB	1.94 MB	✓

github-actions · 2019-07-15T14:53:03Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	13.6s	13.6s	-5ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	-1 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	⚠️ +1 B
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	224 B	222 B	-2 B
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	300 B	301 B	⚠️ +1 B
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.36 kB	1.36 kB	✓
Build Dir Size	756 kB	756 kB	✓

Click to expand serverless stats

	zeit/next.js canary	nataliemarleny/next.js fix-issue7836	Change
Build Duration	14.1s	14.1s	-58ms
`node_modules` Size	45.4 MB	45.4 MB	⚠️ +4.88 kB
Total Bundle (main, webpack, commons) Size	210 kB	210 kB	✓
Total Bundle (main, webpack, commons) gzip Size	68.8 kB	68.8 kB	✓
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.45 kB	8.45 kB	✓
Client `_error` gzip Size	3.24 kB	3.24 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.14 kB	4.14 kB	✓
Client `pages/link` gzip Size	1.82 kB	1.82 kB	✓
Client `pages/routerDirect` Size	423 B	423 B	✓
Client `pages/routerDirect` gzip Size	306 B	306 B	✓
Client `pages/withRouter` Size	435 B	435 B	✓
Client `pages/withRouter` gzip Size	301 B	301 B	✓
Client `main` Size	23.7 kB	23.7 kB	✓
Client `main` gzip Size	7.81 kB	7.81 kB	✓
Client `commons` Size	184 kB	184 kB	✓
Client `commons` gzip Size	59.7 kB	59.7 kB	✓
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	338 kB	338 kB	✓
Serverless `pages/link` gzip Size	86.7 kB	86.7 kB	✓
Serverless `pages/index` Size	Error getting size	Error getting size	✓
Serverless `pages/index` gzip Size	Error getting size	Error getting size	✓
Serverless `pages/_error` Size	328 kB	328 kB	✓
Serverless `pages/_error` gzip Size	84 kB	84 kB	✓
Serverless `pages/routerDirect` Size	329 kB	329 kB	✓
Serverless `pages/routerDirect` gzip Size	84.3 kB	84.3 kB	✓
Serverless `pages/withRouter` Size	329 kB	329 kB	✓
Serverless `pages/withRouter` gzip Size	84.3 kB	84.3 kB	✓
Build Dir Size	1.94 MB	1.94 MB	✓

timneutkens

Looks good to me 💯

nataliemarleny requested review from ijjk, lfades, Timer and timneutkens as code owners July 14, 2019 13:12

huv1k reviewed Jul 14, 2019

View reviewed changes

packages/next/build/index.ts Outdated Show resolved Hide resolved

Natalie Marleny and others added 6 commits July 15, 2019 15:33

Update autoExport wording to automatic static optimization

6d7855f

Add sufficiently informative error message

b1dbb77

- Update other Next error message for consistency

Implement feedback - add missing character

d295dd6

Co-Authored-By: Lukáš Huvar <[email protected]>

Fix TypeScript errors

3283884

Update test from autoExport to automatic static optimization

87dce27

- Also reflect new wording of error message for readability

Add test for handle non-page in pages

ae2a76d

- When target: severless

Merge branch 'canary' into fix-issue7836

86fa78c

Timer added this to the 9.0.2 milestone Jul 15, 2019

Timer added Type: Bug labels Jul 15, 2019

timneutkens approved these changes Jul 15, 2019

View reviewed changes

timneutkens merged commit e68a5a7 into vercel:canary Jul 15, 2019

nataliemarleny deleted the fix-issue7836 branch July 15, 2019 15:18

stan-sack mentioned this pull request Aug 11, 2019

TypeError: Cannot read property 'edges' of undefined #8141

Closed

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Ensure ergonomic handling of non-page in `./pages/` #7955

fix: Ensure ergonomic handling of non-page in `./pages/` #7955

nataliemarleny commented Jul 14, 2019 •

edited

Loading

github-actions bot commented Jul 14, 2019

github-actions bot commented Jul 14, 2019

github-actions bot commented Jul 14, 2019

github-actions bot commented Jul 15, 2019

github-actions bot commented Jul 15, 2019

timneutkens left a comment

fix: Ensure ergonomic handling of non-page in ./pages/ #7955

fix: Ensure ergonomic handling of non-page in ./pages/ #7955

Conversation

nataliemarleny commented Jul 14, 2019 • edited Loading

Handling a non-page in ./pages when target: serverless':

Error Message after fix:

Error Message prior to fix:

github-actions bot commented Jul 14, 2019

Stats from current PR

github-actions bot commented Jul 14, 2019

Stats from current PR

github-actions bot commented Jul 14, 2019

Stats from current PR

github-actions bot commented Jul 15, 2019

Stats from current PR

github-actions bot commented Jul 15, 2019

Stats from current PR

timneutkens left a comment

Choose a reason for hiding this comment

fix: Ensure ergonomic handling of non-page in `./pages/` #7955

fix: Ensure ergonomic handling of non-page in `./pages/` #7955

nataliemarleny commented Jul 14, 2019 •

edited

Loading

Handling a non-page in `./pages` when `target: serverless'`: