CiManager.add and AttributeValueManager.create_or_update_attr_value update #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(CiManager.add()): Check the attribute is in the ci_type attributes list
feat(AttributeValueManager.create_or_update_attr_value()): AttributeValue update skip The same value
feat(AttributeValueManager.create_or_update_attr_value()): AttributeValue update skip The same value
兼容 py2
value type 是 int 或 float 时 value 值等于 0 是会删除 的 BUG
pycook
added a commit
that referenced
this pull request
Jul 19, 2023
CiManager.add and AttributeValueManager.create_or_update_attr_value update
pycook
added a commit
that referenced
this pull request
Nov 7, 2023
CiManager.add and AttributeValueManager.create_or_update_attr_value update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(CiManager.add()): attr 属性是否在 ci_type 的 attr 列表中,如果不在就跳过
feat(AttributeValueManager.create_or_update_attr_value()): value 相同是跳过不更新
fix(AttributeValueManager.create_or_update_attr_value()): value type 是 int 或 float 时 value 值等于 0 是会删除 的 BUG