feat: extend conditions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend conditions with error and zero value in case of missing args
alex-poliushkin
approved these changes
Jun 2, 2023
| @@ -116,8 +116,8 @@ func TestAllowFiltering(t *testing.T) { | |||
| b := new(ResourceSelectBuilder) | |||
| const conditionName = "c1" | |||
| conditions := ConditionMap{ | |||
| conditionName: func(field string, args ...interface{}) Sqlizer { | |||
| return nil | |||
| conditionName: func(field string, args ...interface{}) (Sqlizer, error) { | |||
There was a problem hiding this comment.
@umalmyha move this rule to the .golangci.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend conditions with error and zero value in case of missing args