Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump typing_extensions python to 3.14 #3593

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Sep 17, 2024

Related

Description

Updates python_version<"3.13" -> python_version<"3.14".

This was already required due to multiple instances of importing typing_extensions without a version guard.
However, we are also using PEP 728 which hasn't landed in time for 3.13.

Existing usage on main

class _ConditionExtra(TypedDict, closed=True, total=False): # type: ignore[call-arg]
# https://peps.python.org/pep-0728/
# Likely a Field predicate
empty: Optional[bool]
param: Parameter | str
test: _TestPredicateType
value: Any
__extra_items__: _StatementType | OneOrSeq[_LiteralValue]
_Condition: TypeAlias = _ConditionExtra
"""A singular, non-chainable condition produced by ``.when()``."""
_Conditions: TypeAlias = t.List[_ConditionClosed]
"""Chainable conditions produced by ``.when()`` and ``Then.when()``."""
_C = TypeVar("_C", _Conditions, _Condition)
class _Conditional(TypedDict, t.Generic[_C], total=False):
condition: Required[_C]
value: Any
class _Value(TypedDict, closed=True, total=False): # type: ignore[call-arg]
# https://peps.python.org/pep-0728/
value: Required[Any]
__extra_items__: Any

Updating this is now a higher priority due to scheduled release of 3.13 on 2024-10-01 (14 days away)

@dangotbanned dangotbanned added maintenance dependencies Pull requests that update a dependency file labels Sep 17, 2024
@binste binste merged commit 62cd377 into main Sep 17, 2024
27 checks passed
@dangotbanned dangotbanned deleted the update-typing-ext-bound branch September 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants