Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Fix nextest / rustup dll issue #20544

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

jszwedko
Copy link
Member

Workaround for issue in nextest caused by a change in rustup: nextest-rs/nextest#1493

Fixes:

error: creating test list failed

Caused by:
  for `vector-config-macros`, command
  `'C:\a\vector\vector\target\debug\deps\vector_config_macros-4fc11cf764d99dff.exe' --list --format
  terse` exited with code 0xc0000135: The specified module could not be found. (os error 126)

Workaround for issue in nextest caused by a change in rustup:
nextest-rs/nextest#1493

Fixes:

```
error: creating test list failed

Caused by:
  for `vector-config-macros`, command
  `'C:\a\vector\vector\target\debug\deps\vector_config_macros-4fc11cf764d99dff.exe' --list --format
  terse` exited with code 0xc0000135: The specified module could not be found. (os error 126)
```

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 21, 2024
@jszwedko
Copy link
Member Author

/ci-run-unit-windows

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label May 21, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/fix-windows-ci
Commit report: 8398f7e
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.4s Total Time

@jszwedko jszwedko enabled auto-merge May 21, 2024 20:05
@jszwedko jszwedko added this pull request to the merge queue May 21, 2024
Copy link

Regression Detector Results

Run ID: 3f23d160-b3e4-4835-a76b-d5cac4704fd7
Baseline: 911e63d
Comparison: 50ef76b
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_regex_logs2metric_ddmetrics ingress throughput +2.00 [+1.85, +2.16]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.84 [+1.75, +1.94]
syslog_splunk_hec_logs ingress throughput +1.66 [+1.58, +1.74]
splunk_hec_route_s3 ingress throughput +1.12 [+0.67, +1.58]
otlp_grpc_to_blackhole ingress throughput +0.86 [+0.77, +0.96]
fluent_elasticsearch ingress throughput +0.58 [+0.10, +1.06]
file_to_blackhole egress throughput +0.48 [-1.99, +2.96]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.36 [+0.22, +0.50]
datadog_agent_remap_datadog_logs ingress throughput +0.22 [+0.11, +0.33]
http_to_http_noack ingress throughput +0.12 [+0.03, +0.21]
http_to_http_json ingress throughput +0.07 [-0.01, +0.15]
syslog_log2metric_humio_metrics ingress throughput +0.05 [-0.06, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.13, +0.15]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
enterprise_http_to_http ingress throughput -0.02 [-0.10, +0.07]
http_elasticsearch ingress throughput -0.04 [-0.11, +0.03]
datadog_agent_remap_blackhole_acks ingress throughput -0.04 [-0.13, +0.05]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.16, +0.06]
datadog_agent_remap_blackhole ingress throughput -0.23 [-0.33, -0.14]
syslog_humio_logs ingress throughput -0.24 [-0.35, -0.13]
http_to_s3 ingress throughput -0.27 [-0.55, +0.01]
socket_to_socket_blackhole ingress throughput -0.44 [-0.51, -0.38]
http_text_to_http_json ingress throughput -0.49 [-0.62, -0.36]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.49 [-0.60, -0.39]
otlp_http_to_blackhole ingress throughput -0.73 [-0.84, -0.61]
http_to_http_acks ingress throughput -1.03 [-2.39, +0.32]
syslog_loki ingress throughput -1.34 [-1.42, -1.26]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 50ef76b May 21, 2024
55 checks passed
@jszwedko jszwedko deleted the jszwedko/fix-windows-ci branch May 21, 2024 21:14
paomian pushed a commit to paomian/vector that referenced this pull request Jun 12, 2024
Workaround for issue in nextest caused by a change in rustup:
nextest-rs/nextest#1493

Fixes:

```
error: creating test list failed

Caused by:
  for `vector-config-macros`, command
  `'C:\a\vector\vector\target\debug\deps\vector_config_macros-4fc11cf764d99dff.exe' --list --format
  terse` exited with code 0xc0000135: The specified module could not be found. (os error 126)
```

Signed-off-by: Jesse Szwedko <[email protected]>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Workaround for issue in nextest caused by a change in rustup:
nextest-rs/nextest#1493

Fixes:

```
error: creating test list failed

Caused by:
  for `vector-config-macros`, command
  `'C:\a\vector\vector\target\debug\deps\vector_config_macros-4fc11cf764d99dff.exe' --list --format
  terse` exited with code 0xc0000135: The specified module could not be found. (os error 126)
```

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants