add test for internal/errors/runtime #984

vankichi · 2021-02-04T11:16:52Z

Signed-off-by: vankichi [email protected]

Description:

I added the test for internal/errors/runtime.go and add comment for each function.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.7
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.13.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vankichi · 2021-02-04T11:17:00Z

/format

vdaas-ci · 2021-02-04T11:17:11Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci · 2021-02-04T11:18:35Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

internal/errors/runtime_test.go

github-actions · 2021-02-04T11:24:27Z

internal/errors/runtime_test.go

+			}
+		}(),
+		func() test {
+			tString := "10h"


🚫 [golangci] _{reported by reviewdog 🐶}
string 10h has 3 occurrences, make it a constant (goconst)

internal/errors/runtime_test.go

github-actions · 2021-02-04T11:24:27Z

internal/errors/runtime_test.go

+			}
+		}(),
+	}
+	for _, tc := range tests {


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

github-actions · 2021-02-04T11:24:27Z

internal/errors/runtime_test.go

+			}
+		}(),
+	}
+	for _, tc := range tests {


🚫 [golangci] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

codecov · 2021-02-04T11:26:36Z

Codecov Report

Merging #984 (722a6ea) into master (81c93d3) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   14.43%   14.45%   +0.02%     
==========================================
  Files         492      492              
  Lines       27906    27906              
==========================================
+ Hits         4028     4035       +7     
+ Misses      23640    23633       -7     
  Partials      238      238

Impacted Files	Coverage Δ
internal/errors/runtime.go	`100.00% <ø> (+100.00%)`	⬆️
internal/worker/worker.go	`82.29% <0.00%> (-1.05%)`	⬇️
internal/worker/queue.go	`98.33% <0.00%> (+3.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c93d3...5927318. Read the comment docs.

internal/errors/runtime.go

hlts2 · 2021-02-08T00:36:47Z

internal/errors/runtime_test.go

+					rec: r,
+				},
+				want: want{
+					want: Wrap(defaultErr, Errorf("panic recovered: %v", r).Error()),


Should we use New function insted of Wrap function. 🤔
because this want is equal to the test target function like this. 🤔

vald/internal/errors/runtime.go

Line 25 in 1b6993b

return Wrap(err, Errorf("panic recovered: %v", rec).Error())

if we'd like to test the Wrap function, I agree with you.
IMO, about this case, it is not needed.
How do you think?

I got it 👍 I agree with you!

internal/errors/runtime_test.go

github-actions · 2021-02-08T01:08:01Z

internal/errors/runtime_test.go

+	}
+	defaultErr := New("runtime panic string error")
+	defaultRuntimeErr := &runtimeErr{
+		err: New("runtime error is occured"),


🚫 [golangci] _{reported by reviewdog 🐶}
occured is a misspelling of occurred (misspell)

internal/errors/runtime_test.go

kevindiu

LGTM

kevindiu · 2021-02-08T04:51:25Z

/rebase
/format
/approve

vdaas-ci · 2021-02-08T04:52:06Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-runtime

vdaas-ci · 2021-02-08T04:55:13Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci

[APPROVED] This PR is approved by kevindiu.

kevindiu · 2021-02-08T09:50:43Z

/rebase
/format
/approve

vdaas-ci · 2021-02-08T09:51:28Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-runtime

Signed-off-by: vankichi <[email protected]>

Signed-off-by: vdaas-ci <[email protected]>

Co-authored-by: Hiroto Funakoshi <[email protected]>

Signed-off-by: vankichi <[email protected]>

Co-authored-by: Kevin Diu <[email protected]>

vdaas-ci · 2021-02-08T09:52:48Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci

[APPROVED] This PR is approved by kevindiu.

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Feb 4, 2021

vankichi requested review from hlts2 and kevindiu February 4, 2021 11:18

vankichi self-assigned this Feb 4, 2021

github-actions bot reviewed Feb 4, 2021

View reviewed changes

hlts2 reviewed Feb 8, 2021

View reviewed changes

vankichi commented Feb 8, 2021

View reviewed changes

internal/errors/runtime_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Feb 8, 2021

View reviewed changes

internal/errors/runtime_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Feb 8, 2021

View reviewed changes

internal/errors/runtime_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Feb 8, 2021

View reviewed changes

hlts2 previously approved these changes Feb 8, 2021

View reviewed changes

kevindiu suggested changes Feb 8, 2021

View reviewed changes

internal/errors/runtime_test.go Outdated Show resolved Hide resolved

internal/errors/runtime_test.go Show resolved Hide resolved

internal/errors/runtime_test.go Show resolved Hide resolved

internal/errors/runtime_test.go Outdated Show resolved Hide resolved

vankichi dismissed hlts2’s stale review via c847b89 February 8, 2021 02:57

kevindiu previously approved these changes Feb 8, 2021

View reviewed changes

vdaas-ci dismissed kevindiu’s stale review via 49bbfaa February 8, 2021 04:52

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-runtime branch from e06e383 to 49bbfaa Compare February 8, 2021 04:52

vdaas-ci previously approved these changes Feb 8, 2021

View reviewed changes

vankichi and others added 8 commits February 8, 2021 09:51

✅ add test for internal/errors/runtime

43f691e

Signed-off-by: vankichi <[email protected]>

🤖 Update license headers / Format go codes and yaml files

b58d27a

Signed-off-by: vdaas-ci <[email protected]>

Update internal/errors/runtime.go

883c668

Co-authored-by: Hiroto Funakoshi <[email protected]>

Update internal/errors/runtime.go

958a095

Co-authored-by: Hiroto Funakoshi <[email protected]>

Update internal/errors/runtime.go

c482de6

Co-authored-by: Hiroto Funakoshi <[email protected]>

Update internal/errors/runtime_test.go

2f7c0a9

✅ update runtime_test with feedback

50ea9f0

Signed-off-by: vankichi <[email protected]>

Update internal/errors/runtime_test.go

5927318

Co-authored-by: Kevin Diu <[email protected]>

vdaas-ci dismissed their stale review via 5927318 February 8, 2021 09:51

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-runtime branch from 49bbfaa to 5927318 Compare February 8, 2021 09:51

vdaas-ci approved these changes Feb 8, 2021

View reviewed changes

kevindiu merged commit 2eb8668 into master Feb 8, 2021

kevindiu deleted the test/internal/add-newtest-for-errors-runtime branch February 8, 2021 10:01

This was referenced Feb 9, 2021

[patch] Bug fix on StreamGetObject API and DNS cache expiration / refactor net connection #986

Merged

[patch] v1.0.2 Release #998

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add test for internal/errors/runtime #984

add test for internal/errors/runtime #984

vankichi commented Feb 4, 2021

vankichi commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

github-actions bot Feb 4, 2021

github-actions bot Feb 4, 2021

github-actions bot Feb 4, 2021

codecov bot commented Feb 4, 2021 •

edited

Loading

hlts2 Feb 8, 2021 •

edited

Loading

vankichi Feb 8, 2021

hlts2 Feb 8, 2021

github-actions bot Feb 8, 2021

kevindiu left a comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

add test for internal/errors/runtime #984

add test for internal/errors/runtime #984

Conversation

vankichi commented Feb 4, 2021

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vankichi commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

codecov bot commented Feb 4, 2021 • edited Loading

Codecov Report

hlts2 Feb 8, 2021 • edited Loading

Choose a reason for hiding this comment

vankichi Feb 8, 2021

Choose a reason for hiding this comment

hlts2 Feb 8, 2021

Choose a reason for hiding this comment

github-actions bot Feb 8, 2021

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 4, 2021 •

edited

Loading

hlts2 Feb 8, 2021 •

edited

Loading