Create s3/session test #702

kevindiu · 2020-09-15T23:30:18Z

Description:

This PR implements internal s3/session.go test.
It includes the refactoring on FOP base on the coding guideline

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-09-15T23:30:21Z

Best reviewed: commit by commit

Optimal code review plan

Powered by Pull Assistant. Last update 34d34ed ... a815d53. Read the comment docs.

vdaas-ci · 2020-09-15T23:30:36Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/test/comparator/standard.go

codecov · 2020-09-15T23:36:36Z

Codecov Report

Merging #702 into master will increase coverage by 0.34%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   14.31%   14.66%   +0.34%     
==========================================
  Files         419      419              
  Lines       19420    19449      +29     
==========================================
+ Hits         2780     2852      +72     
+ Misses      16406    16372      -34     
+ Partials      234      225       -9

Impacted Files	Coverage Δ
pkg/gateway/vald/handler/grpc/handler.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/s3/session/option.go	`52.38% <46.80%> (+52.38%)`	⬆️
internal/db/storage/blob/s3/session/session.go	`94.59% <100.00%> (+94.59%)`	⬆️
internal/worker/queue.go	`100.00% <0.00%> (+1.66%)`	⬆️
internal/worker/worker.go	`84.37% <0.00%> (+3.12%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1dabb...a815d53. Read the comment docs.

kevindiu · 2020-09-17T07:29:31Z

/rebase

vdaas-ci · 2020-09-17T07:30:10Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

kevindiu · 2020-09-23T05:32:13Z

/rebase

vdaas-ci · 2020-09-23T05:32:50Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

hlts2

LGTM

vankichi

@kevindiu leave comments

internal/db/storage/blob/s3/session/session_test.go

vankichi

LGTM

hlts2

LGTM

vankichi · 2020-09-24T05:20:58Z

/rebase
/format
/approve

vdaas-ci · 2020-09-24T05:21:31Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

vdaas-ci · 2020-09-24T05:22:33Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

kevindiu · 2020-09-24T07:38:15Z

/rebase

vdaas-ci · 2020-09-24T07:38:52Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

internal/test/comparator/standard.go

internal/db/storage/blob/s3/session/session_test.go

hlts2

LGTM

vankichi · 2020-09-28T09:47:44Z

/rebase
/format
/approve

vdaas-ci · 2020-09-28T09:48:21Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

vdaas-ci · 2020-09-28T09:49:23Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi · 2020-09-29T01:54:23Z

/rebase
/format
/approve

vdaas-ci · 2020-09-29T01:54:58Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

vdaas-ci · 2020-09-29T01:55:59Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Sep 15, 2020

github-actions bot reviewed Sep 15, 2020

View reviewed changes

kevindiu changed the title ~~Create s3/session test~~ [WIP] Create s3/session test Sep 16, 2020

vdaas-ci force-pushed the test/internal/add-test-s3-session branch from 00c1d0a to b17bd44 Compare September 17, 2020 07:30

kevindiu changed the title ~~[WIP] Create s3/session test~~ Create s3/session test Sep 23, 2020

kevindiu requested a review from hlts2 September 23, 2020 05:29

vdaas-ci force-pushed the test/internal/add-test-s3-session branch from f6f2e1e to 86ff508 Compare September 23, 2020 05:33

hlts2 previously approved these changes Sep 23, 2020

View reviewed changes

vankichi reviewed Sep 23, 2020

View reviewed changes

internal/db/storage/blob/s3/session/session_test.go Outdated Show resolved Hide resolved

kevindiu dismissed hlts2’s stale review via a491186 September 23, 2020 09:38

vankichi reviewed Sep 24, 2020

View reviewed changes

internal/db/storage/blob/s3/session/session_test.go Outdated Show resolved Hide resolved

vankichi previously approved these changes Sep 24, 2020

View reviewed changes

hlts2 previously approved these changes Sep 24, 2020

View reviewed changes

vdaas-ci dismissed stale reviews from hlts2 and vankichi via 898f0cd September 24, 2020 05:21

vdaas-ci force-pushed the test/internal/add-test-s3-session branch from c641a28 to 898f0cd Compare September 24, 2020 05:21

kevindiu dismissed vdaas-ci’s stale review via c0018c6 September 24, 2020 07:37

vdaas-ci force-pushed the test/internal/add-test-s3-session branch from c0018c6 to b41a3d5 Compare September 24, 2020 07:39

github-actions bot reviewed Sep 24, 2020

View reviewed changes

internal/test/comparator/standard.go Show resolved Hide resolved

internal/db/storage/blob/s3/session/session_test.go Show resolved Hide resolved

hlts2 previously approved these changes Sep 24, 2020

View reviewed changes

kevindiu requested a review from vankichi September 25, 2020 01:10

vankichi previously approved these changes Sep 28, 2020

View reviewed changes

kevindiu and others added 5 commits September 28, 2020 09:48

add test

34d34ed

add session test

7160802

fix

dcf152d

fix

09f7541

Remove unused code

7267e77

vdaas-ci dismissed stale reviews from vankichi and hlts2 via 7267e77 September 28, 2020 09:48

vdaas-ci force-pushed the test/internal/add-test-s3-session branch from b41a3d5 to 7267e77 Compare September 28, 2020 09:48

vdaas-ci previously approved these changes Sep 28, 2020

View reviewed changes

comment unused code

a815d53

kevindiu dismissed vdaas-ci’s stale review via a815d53 September 29, 2020 01:39

hlts2 approved these changes Sep 29, 2020

View reviewed changes

vankichi approved these changes Sep 29, 2020

View reviewed changes

vdaas-ci approved these changes Sep 29, 2020

View reviewed changes

vankichi merged commit 3eb2dd9 into master Sep 29, 2020

vankichi deleted the test/internal/add-test-s3-session branch September 29, 2020 04:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create s3/session test #702

Create s3/session test #702

kevindiu commented Sep 15, 2020 •

edited

Loading

pull-assistant bot commented Sep 15, 2020 •

edited

Loading

vdaas-ci commented Sep 15, 2020

codecov bot commented Sep 15, 2020 •

edited

Loading

kevindiu commented Sep 17, 2020

vdaas-ci commented Sep 17, 2020

kevindiu commented Sep 23, 2020

vdaas-ci commented Sep 23, 2020

hlts2 left a comment

vankichi left a comment

vankichi left a comment

hlts2 left a comment

vankichi commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

kevindiu commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

hlts2 left a comment

vankichi commented Sep 28, 2020

vdaas-ci commented Sep 28, 2020

vdaas-ci commented Sep 28, 2020

vdaas-ci left a comment

vankichi commented Sep 29, 2020

vdaas-ci commented Sep 29, 2020

vdaas-ci commented Sep 29, 2020

vdaas-ci left a comment

Create s3/session test #702

Create s3/session test #702

Conversation

kevindiu commented Sep 15, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Sep 15, 2020 • edited Loading

vdaas-ci commented Sep 15, 2020

codecov bot commented Sep 15, 2020 • edited Loading

Codecov Report

kevindiu commented Sep 17, 2020

vdaas-ci commented Sep 17, 2020

kevindiu commented Sep 23, 2020

vdaas-ci commented Sep 23, 2020

hlts2 left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

kevindiu commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Sep 28, 2020

vdaas-ci commented Sep 28, 2020

vdaas-ci commented Sep 28, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Sep 29, 2020

vdaas-ci commented Sep 29, 2020

vdaas-ci commented Sep 29, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Sep 15, 2020 •

edited

Loading

pull-assistant bot commented Sep 15, 2020 •

edited

Loading

codecov bot commented Sep 15, 2020 •

edited

Loading