Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix & upgrade manifests to operator-sdk v1.0.0 compatible #667

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Sep 3, 2020

Signed-off-by: Rintaro Okamura [email protected]

Description:

there're breaking changes in Operator-SDK v0.19.x -> v1.0.0 upgrades.
it is required to upgrade our manifests for it.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.15.1
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Sep 3, 2020

Score: 0.97

Best reviewed: commit by commit


Optimal code review plan

     🐛 fix & upgrade manifests to operator-sdk v1.0.0 compatible

     ⬆️ upgrade rbac.authorization.k8s.io version

     🐛 fix passing arguments

Powered by Pull Assistant. Last update 05d0859 ... 28a7a86. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx
Copy link
Contributor Author

rinx commented Sep 3, 2020

helm lint error is because of helm/helm#8621

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx rinx marked this pull request as ready for review September 3, 2020 06:33
@rinx rinx merged commit 033c2a6 into master Sep 3, 2020
@rinx rinx deleted the bugfix/helm-operator/upgrade-manifests-to-osdk-v1.0.0 branch September 3, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants