internal/tls test

[kevindiu]

Just in case I think we need author review for the tls/tls.go file.

Description:

This PR implements the test case of internal/tls package.
The test coverage is 93%. The missing test case is as the follow:

1. Option will never return error so for example tls.go:48 cannot be covered.
2. no error return from x509.SystemCertPool() call so tls.go:113 cannot be covered.

It also include the new package implementation called test to get the test data path.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.3
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.11.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/tls

[codecov]

Codecov Report

Merging #485 into master will increase coverage by 0.37%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage    9.79%   10.17%   +0.37%     
==========================================
  Files         402      403       +1     
  Lines       20859    20874      +15     
==========================================
+ Hits         2044     2124      +80     
+ Misses      18558    18490      -68     
- Partials      257      260       +3     

Impacted Files	Coverage Δ
internal/cache/gache/gache.go	0.00% <0.00%> (ø)
internal/cache/gache/option.go	0.00% <0.00%> (-6.67%)	⬇️
internal/test/testdata.go	72.72% <72.72%> (ø)
internal/tls/option.go	100.00% <100.00%> (+100.00%)	⬆️
internal/tls/tls.go	84.78% <100.00%> (+84.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845c43e...5e2c0c5. Read the comment docs.

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/tls

[kevindiu]

/rebase

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/tls

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/tls

[hlts2]

thank you for your PR.
LGTM

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.

[vankichi]

/rebase
/format
/approve

[vankichi]

/format
/approve

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.