Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug on /changelog command #450

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fix a bug on /changelog command #450

merged 1 commit into from
Jun 9, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 9, 2020

Signed-off-by: Rintaro Okamura [email protected]

Description:

  • Fixed a bug on /changelog command
  • Revised the format of the messages.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@rinx
🐛 Fix bug on /changelog command
e249ee6 
Signed-off-by: Rintaro Okamura <[email protected]>
@pull-assistant
Copy link

pull-assistant bot commented Jun 9, 2020

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     🐛 Fix bug on /changelog command

Powered by Pull Assistant. Last update e249ee6 ... e249ee6. Read the comment docs.

kpango
kpango approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 424fd5b into master Jun 9, 2020
@kpango kpango deleted the ci/chatops/revise-changelog-command branch June 9, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinx @kpango