Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixinternal/log/format to match the test template #369

Merged
merged 2 commits into from
May 13, 2020
Merged

Fixinternal/log/format to match the test template #369

merged 2 commits into from
May 13, 2020

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented May 11, 2020 •
edited
Loading

Signed-off-by: hlts2 [email protected]

Description:

I fixed internal/log/foramt to match the test template.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented May 11, 2020 •
edited
Loading

Score: 0.99

Best reviewed: commit by commit

Optimal code review plan

     fix: to match the test template

     fix: improve syntax

Powered by Pull Assistant. Last update 36e587d ... 11bac57. Read the comment docs.

@hlts2
Copy link
Contributor Author

hlts2 commented May 11, 2020

/rebase

@hlts2 hlts2 requested review from kevindiu and kmrmt May 11, 2020 06:57
@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_format_test

@kevindiu
Copy link
Contributor

LGTM

@hlts2 hlts2 changed the title internal/log/format: fixed to match the test template Fixinternal/log/format to match the test template May 11, 2020
@hlts2
Copy link
Contributor Author

hlts2 commented May 11, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_format_test

@kevindiu kevindiu self-assigned this May 12, 2020
@hlts2
Copy link
Contributor Author

hlts2 commented May 12, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/log_format_test

@vdaas-ci vdaas-ci force-pushed the test/internal/log_format_test branch from 60b30fa to 5a8a4b8 Compare May 12, 2020 02:09
@codecov
Copy link

codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #369 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #369   +/-   ##
======================================
  Coverage    7.90%   7.91%           
======================================
  Files         346     346           
  Lines       17804   17796    -8     
======================================
  Hits         1408    1408           
+ Misses      16215   16207    -8     
  Partials      181     181
Impacted Files Coverage Δ
internal/config/compress.go 0.00% <0.00%> (ø)
pkg/manager/compressor/usecase/compressord.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78486eb...11bac57. Read the comment docs.

@vankichi
Copy link
Contributor

/format

vankichi
vankichi previously approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi requested review from kpango and rinx May 12, 2020 08:42
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vankichi
Copy link
Contributor

@kpango @rinx
Could you please review, if you have time?

rinx
rinx previously approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. 👍

@kpango
Copy link
Collaborator

kpango commented May 13, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: test/internal/log_format_test

@vdaas-ci vdaas-ci dismissed stale reviews from rinx and vankichi via 11bac57 May 13, 2020 09:14
@vdaas-ci vdaas-ci force-pushed the test/internal/log_format_test branch from 5a8a4b8 to 11bac57 Compare May 13, 2020 09:14
@kpango kpango merged commit ff57649 into master May 13, 2020
@kpango kpango deleted the test/internal/log_format_test branch May 13, 2020 09:16
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu left review comments

@rinx rinx rinx left review comments

@vankichi vankichi vankichi left review comments

@kmrmt kmrmt Awaiting requested review from kmrmt

@kpango kpango Awaiting requested review from kpango

Assignees

@kevindiu kevindiu

Labels
area/internal priority/low size/L status/author-review team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hlts2 @vdaas-ci @kevindiu @vankichi @kpango @rinx