Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Revise backup/meta Cassandra default values #336

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Apr 17, 2020

Description:

Revise Cassandra default values.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Apr 17, 2020

Score: 0.96

Best reviewed: commit by commit


Optimal code review plan

     🔧 Revise default values of Cassandra configs

     🔧 Fix write-coalesce-wait-time

     ♻️ Refactor default values

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update bbbbfb7 ... 045ecaf. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@rinx
Copy link
Contributor Author

rinx commented Apr 20, 2020

/rebase

@github-actions github-actions bot removed the size/S label Apr 20, 2020
@rinx rinx marked this pull request as ready for review April 20, 2020 07:55
@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: refactor/helm-cassandra/default-values

@vdaas-ci vdaas-ci force-pushed the refactor/helm-cassandra/default-values branch from fab017e to 7ec2a0c Compare April 20, 2020 07:56
@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango
Copy link
Collaborator

kpango commented Apr 20, 2020

LGTM
/format
/approve

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango merged commit bb36f8a into master Apr 20, 2020
@kpango kpango deleted the refactor/helm-cassandra/default-values branch April 20, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants