Delete unnecessary code for mirror #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
- Coverage 18.70% 18.69% -0.01%
==========================================
Files 548 548
Lines 73803 73801 -2
==========================================
- Hits 13805 13798 -7
- Misses 59261 59268 +7
+ Partials 737 735 -2 ☔ View full report in Codecov by Sentry. |
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/fix%2Fmirror%2Fdelete-mirror-register/a303d78a980a84eba6b5e2a7584ed19cd2e6f5f6 |
Signed-off-by: hlts2 <[email protected]>
Deploying with
|
| Latest commit: |
e6b96f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00667a25.vald.pages.dev |
| Branch Preview URL: | https://fix-mirror-delete-mirror-reg.vald.pages.dev |
hlts2
added
actions/e2e-deploy
actions/e2e-chaos
and removed
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-profiling
actions/e2e-max-dim
labels
hlts2
added
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-max-dim
and removed
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-max-dim
labels
hlts2
requested review from
a team and
ykadowak
and removed request for
a team
kpango
approved these changes
Feb 20, 2024
ykadowak
reviewed
Feb 20, 2024
ykadowak
approved these changes
Feb 20, 2024
vdaas-ci
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix: delete unnecessary code for mirror Signed-off-by: hlts2 <[email protected]> * fix: make deps/install and format Signed-off-by: hlts2 <[email protected]> * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * fix: naming of variable Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]>
hlts2
added a commit
that referenced
this pull request
Feb 20, 2024
* fix: delete unnecessary code for mirror * fix: make deps/install and format * improve Backport Pull Request Title & Description Quality (#2373) * fix: naming of variable --------- Signed-off-by: hlts2 <[email protected]> Signed-off-by: kpango <[email protected]> Co-authored-by: Hiroto Funakoshi <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]>
This was referenced Mar 1, 2024
kpango
added a commit
that referenced
this pull request
May 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Signed-off-by: kpango <[email protected]>
kpango
added a commit
that referenced
this pull request
May 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Signed-off-by: kpango <[email protected]>
kpango
added a commit
that referenced
this pull request
May 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Signed-off-by: kpango <[email protected]>
hlts2
added a commit
that referenced
this pull request
May 8, 2024
* fix: git add chart directory for release (#2356) Signed-off-by: hlts2 <[email protected]> * 🔖 🤖 Release v1.7.11 (#2360) (#2361) * 🔖 🤖 Release v1.7.11 * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 578746e according to the output from Gofumpt and Prettier. Details: #2360 --------- Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Change docker scan timeout longer (#2363) * refactor code using golangci-lint (#2362) Signed-off-by: kpango <[email protected]> * Create SECURITY.md (#2367) * Create SECURITY.md Signed-off-by: Yusuke Kato <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in e8609b0 according to the output from Gofumpt and Prettier. Details: #2367 --------- Signed-off-by: Yusuke Kato <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * add commit hash build image (#2359) Signed-off-by: kpango <[email protected]> * Make agent export index metrics to Pod k8s resource (#2319) * Add config * Add clusterRole and serviceAccount for agent * Add more metrics * Format * Add export index info duration configuration * Refactor internal/k8s * Move apply function to internal/k8s * Add more config * Remove unused import and variable * Use vald errors * Add pod name and pod namespace to hack e2e agent * Apply tagalign * Revert unnecesarry specification of PodName * Enable export index info to Kubernetes in agent templates only when the config is enabled * Fix agent clusterrole name * Update key name * Update comments * Add index count as export metrics * Ignore gomnd * Add index count entry to exportMetricsOnCreateIndex function * Update values schema * Fix formatter job * Remove unused defines * update docker build target platform selection rules (#2370) Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kadowaki <[email protected]> * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * Update workflow to release readreplica chart (#2383) * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * Add readreplica chart release * update k8s/readreplica * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 70f1dad according to the output from Gofumpt and Prettier. Details: #2383 * [bugfix] fix backport github value bypass failure (#2378) Signed-off-by: kpango <[email protected]> * Revert backport.yaml --------- Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * 💚 ♻️ Add Con-Bench helm chart to the Vald charts (#2388) Signed-off-by: vankichi <[email protected]> * Delete unnecessary code for mirror (#2366) * fix: delete unnecessary code for mirror Signed-off-by: hlts2 <[email protected]> * fix: make deps/install and format Signed-off-by: hlts2 <[email protected]> * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * fix: naming of variable Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> Signed-off-by: kpango <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * change JP logo to EN logo (#2369) Signed-off-by: kpango <[email protected]> Co-authored-by: taisuou <[email protected]> * Add rotate-all option to rotator (#2305) * Add rotate-all option to rotator * Fix linter warnings * Make it possible to choose multiple rotation target * Add tests for parseReplicaID * Add tests for parseReplicaID * Hide testify in internal * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in dd84674 according to the output from Gofumpt and Prettier. Details: #2305 * Apply format * Lint * Lint --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <[email protected]> * Resolve kvs already closed before last saving (#2390) Signed-off-by: kpango <[email protected]> * create continous benchmark doc (#2352) * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * 📝 create continous benchmark doc Signed-off-by: vankichi <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in ace001a according to the output from Gofumpt and Prettier. Details: #2352 * ♻️ rafactor default params Signed-off-by: vankichi <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 9880dfc according to the output from Gofumpt and Prettier. Details: #2352 * ♻️ Fix format Signed-off-by: vankichi <[email protected]> * Revert "improve Backport Pull Request Title & Description Quality (#2373)" This reverts commit 4246def. * ♻️ remove dimension from con-bench Signed-off-by: vankichi <[email protected]> * 📝 Add sample benchmark manifest Signed-off-by: vankichi <[email protected]> * Update docs/performance/continuos-benchmatk.md Co-authored-by: Yusuke Kato <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> * Update docs/performance/continuos-benchmatk.md Co-authored-by: Hiroto Funakoshi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> --------- Signed-off-by: kpango <[email protected]> Signed-off-by: vankichi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Hiroto Funakoshi <[email protected]> * fix: build error of internal kvs test (#2396) Signed-off-by: hlts2 <[email protected]> * 🤖 Update license headers / Format Go codes and YAML files (#2397) Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: Hiroto Funakoshi <[email protected]> * fix: disable protobuf dispatch for client (#2401) Signed-off-by: hlts2 <[email protected]> * update deps (#2404) Signed-off-by: kpango <[email protected]> * 🔖 🤖 Release v1.7.12 (#2408) (#2409) * 🔖 🤖 Release v1.7.12 * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 5bd8605 according to the output from Gofumpt and Prettier. Details: #2408 --------- Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Add tests for index information export (#2412) * Add tests for index information export * Add comments * 📝 Fix typo of file name (#2413) Signed-off-by: vankichi <[email protected]> * Fix agent-faiss build failed (#2418) * 🐳 Fix agent-faiss build failed Signed-off-by: vankichi <[email protected]> * 🐳 Fix COPY binary Signed-off-by: vankichi <[email protected]> * 🐳 Change COPY binary (use ld-linux-x86-64) Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]> * Fix the logic to determine docker image (#2410) * fix: update action to get tag list Signed-off-by: hlts2 <[email protected]> * fix: refactor sub command execution Signed-off-by: hlts2 <[email protected]> * fix: use tag list in detect ci container workflow Signed-off-by: hlts2 <[email protected]> * fix: name for detected result Signed-off-by: hlts2 <[email protected]> * fix: invalid variable bug Signed-off-by: hlts2 <[email protected]> * fix: execution error and invalid variable Signed-off-by: hlts2 <[email protected]> * fix: deleted unnecessary comment Signed-off-by: hlts2 <[email protected]> * fix: deleted unnecessary parameters Signed-off-by: hlts2 <[email protected]> * fix: use new determine tag logic in the docker build workflow Signed-off-by: hlts2 <[email protected]> * fix: bugfix extra tags handling and small refactor Signed-off-by: hlts2 <[email protected]> * fix: build tag rule or release branch based on tag list Signed-off-by: hlts2 <[email protected]> * fix: typo Signed-off-by: hlts2 <[email protected]> * fix: indent Signed-off-by: hlts2 <[email protected]> * fix: refactor syntax Signed-off-by: hlts2 <[email protected]> * fix: typo and invalid option error Signed-off-by: hlts2 <[email protected]> * fix: use helm extra option Signed-off-by: hlts2 <[email protected]> * fix: add comment for tag management Signed-off-by: hlts2 <[email protected]> * fix: unsetbug of helm extra option Signed-off-by: hlts2 <[email protected]> * fix: build target condition Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> * Update build rule for nightly image (#2421) * fix: update build rule for nightly Signed-off-by: hlts2 <[email protected]> * fix: indent and deleted unnecessary tag Signed-off-by: hlts2 <[email protected]> * fix: update tag name when tag is unknown Signed-off-by: hlts2 <[email protected]> * fix: add secondary tags for build performance Signed-off-by: hlts2 <[email protected]> * fix: argument order Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> * Add `index-operator` template implementation (#2375) * improve Backport Pull Request Title & Description Quality (#2373) Signed-off-by: kpango <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * [bugfix] fix backport github value bypass failure (#2378) Signed-off-by: kpango <[email protected]> * [bugfix] fix backport github value bypass failure (#2381) Signed-off-by: kpango <[email protected]> * Add index operator boilerplate * Add k8s controller * Add pod and job controllers * Add annotations in the pod reconciler * Update auto indexing service configurations * Update WithOnReconcileFunc signature to include context * Refactor debugging log * Refactor reconcile funcs * add nolint * remove unused parameters * lint * Add dockerfile and build ci * remove params * Add index-operator image build command to Makefile * Add index operator k8s templates * Update helm schema * Update readme * Add internal/k8s as a trigger for images that depends on controller-runtime * remove comment * Update pkg/index/operator/service/operator.go Co-authored-by: Yusuke Kato <[email protected]> Signed-off-by: Yusuke Kadowaki <[email protected]> * Update pkg/index/operator/service/operator.go Co-authored-by: Yusuke Kato <[email protected]> Signed-off-by: Yusuke Kadowaki <[email protected]> * Refactor * Add build commands * Refactor Co-authored-by: Yusuke Kato <[email protected]> --------- Signed-off-by: kpango <[email protected]> Signed-off-by: Yusuke Kadowaki <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> * Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) * fix: add outut settings for action Signed-off-by: hlts2 <[email protected]> * fix: tag name for release branch build Signed-off-by: hlts2 <[email protected]> * fix: refactor Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> * fix: typo of execution rule (#2426) Signed-off-by: hlts2 <[email protected]> * Add flush API for deleting all vectors (#2273) * add flush api Signed-off-by: aknishid <[email protected]> * added flush api * fix typo * fix pb.go & fix conflict Signed-off-by: aknishid <[email protected]> * add flush api * add handler Flush Signed-off-by: aknishid <[email protected]> * add vald.Client flush * fix filter gateway Signed-off-by: aknishid <[email protected]> * fix handler cnts Signed-off-by: aknishid <[email protected]> * delete unused var Signed-off-by: aknishid <[email protected]> * add author Signed-off-by: Yamada Takuya <[email protected]> * fix error Signed-off-by: aknishid <[email protected]> * fix flush.go & ngt.go Signed-off-by: aknishid <[email protected]> * add flush to example Signed-off-by: aknishid <[email protected]> * fix gateway lb Signed-off-by: aknishid <[email protected]> * update flush proto Signed-off-by: aknishid <[email protected]> * fix docs api README.md Signed-off-by: aknishid <[email protected]> * Fix flush ctx Signed-off-by: aknishid <[email protected]> * update docs & comment Signed-off-by: aknishid <[email protected]> * after make format Signed-off-by: aknishid <[email protected]> * add e2e Signed-off-by: aknishid <[email protected]> * update example & tutorial Signed-off-by: aknishid <[email protected]> * Update internal/errors/ngt.go Co-authored-by: Kiichiro YUKAWA <[email protected]> * fix review Signed-off-by: aknishid <[email protected]> * modify status.md Signed-off-by: aknishid <[email protected]> * add error handling Signed-off-by: aknishid <[email protected]> * update proto Signed-off-by: aknishid <[email protected]> * fix doc Signed-off-by: aknishid <[email protected]> * ♻️ Fix proto Signed-off-by: vankichi <[email protected]> * use atomic bool Signed-off-by: aknishid <[email protected]> * fix proto Signed-off-by: aknishid <[email protected]> * update proto Signed-off-by: aknishid <[email protected]> * fix gateway error Signed-off-by: aknishid <[email protected]> * ✅ 🚧 Avoid e2e failing due to unimplemented handler and Add unimplmented handler method for the future Signed-off-by: vankichi <[email protected]> * Update apis/proto/v1/payload/payload.proto Co-authored-by: Kiichiro YUKAWA <[email protected]> Signed-off-by: aknishid <[email protected]> --------- Signed-off-by: aknishid <[email protected]> Signed-off-by: Yamada Takuya <[email protected]> Signed-off-by: vankichi <[email protected]> Signed-off-by: aknishid <[email protected]> Co-authored-by: takuyaymd <[email protected]> Co-authored-by: takuyyam <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> * docs: add aknishid as a contributor for code, and maintenance (#2431) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in abc4c52 according to the output from Gofumpt and Prettier. Details: #2431 --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * update deps & add validation for Flush API when agent is Read Only (#2433) Signed-off-by: kpango <[email protected]> * Update README.md (grammer) (#2440) Signed-off-by: Hrichik Mazumder <[email protected]> * docs: add hrichiksite as a contributor for doc (#2441) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in b8054d9 according to the output from Gofumpt and Prettier. Details: #2441 --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Added snapshot timestamp annotations to read replica agent (#2428) * Add lastTimeRotateReplicaTimestampAnnotationsKey constant * Use ptr package * Update annotations in ngt.go and rotator.go * Add labels to Pod struct and update annotations handling*** ***Introduce vald package for k8s related constants*** ***Implement rotateIfNeeded function to check if read replica rotation is needed * Refactor * set sample log level debug * Use k8s timestamp * Refactor * Format * Add MatchingLabels method to ValdK8sClientMock * Format * Fix test * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 39b66fa according to the output from Gofumpt and Prettier. Details: #2428 * Rename constants Co-authored-by: Yusuke Kato <[email protected]> * Refactor rotateIfNeeded function to use label selector for listing deployments * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 6ace761 according to the output from Gofumpt and Prettier. Details: #2428 * FIx deepsource * Revert --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <[email protected]> * fix: bugfix version update for docker build (#2445) Signed-off-by: hlts2 <[email protected]> * Fix index job logic to pass DNS A record (#2438) * fix: choose user given target address in priority Signed-off-by: hlts2 <[email protected]> * fix: deleted unnecessary code Signed-off-by: hlts2 <[email protected]> * fix: add logic to connect the user given target addresses Signed-off-by: hlts2 <[email protected]> * fix: add info log about new connection target Signed-off-by: hlts2 <[email protected]> * fix: indent of configuration data Signed-off-by: hlts2 <[email protected]> * fix: indent bug Signed-off-by: hlts2 <[email protected]> * fix: deepsource warning Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> * Fix operator-sdk version (#2447) * fix: down grade operator version Signed-off-by: hlts2 <[email protected]> * fix: upgrade operator-sdk version Signed-off-by: hlts2 <[email protected]> * fix: operator-sdk version Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> * add file name lint (#2417) Signed-off-by: kpango <[email protected]> * fix: add extra option for ci-container build (#2451) Signed-off-by: hlts2 <[email protected]> * Add base of benchmark operator dashboard (#2430) * 📈 Add base of benchmark operator dashboard Signed-off-by: vankichi <[email protected]> * 💚 Fix build benchmark images trigger Signed-off-by: vankichi <[email protected]> * 💚 Add info tag for info metrics Signed-off-by: vankichi <[email protected]> * 📈 showing job image and tags Signed-off-by: vankichi <[email protected]> * 📈 add bench job status Signed-off-by: vankichi <[email protected]> * ♻️ Update dashboard and rename Signed-off-by: vankichi <[email protected]> * ♻️ Fix Signed-off-by: vankichi <[email protected]> * Update internal/observability/metrics/tools/benchmark/benchmark.go Co-authored-by: Hiroto Funakoshi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> --------- Signed-off-by: vankichi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: Hiroto Funakoshi <[email protected]> * Implement index operator logic for read replica rotation (#2444) * Remove job reconciler * Add leader election to index operator * Add roles for leader election * Add operator logic for rotation * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 844cca1 according to the output from Gofumpt and Prettier. Details: #2444 * Remove unnecesary change * Fix build * nits * Refactor * Fix clusterrole * Move to podv2 * Add job concurrency check * Refactor * Refactor * Fix heavy copying * Update helm schema * Fix package doc * Remove unused code and refactor For() method * Update target read replica ID in config * Update internal/k8s/podv2/option.go Co-authored-by: Hiroto Funakoshi <[email protected]> Signed-off-by: Yusuke Kadowaki <[email protected]> * Refactor * rename podv2 to v2/pod * Add client DI * Fix envkey helper * Set namespace from values.yaml * Use annotations to specify the id * Update schema * Update sample * Update values * Update schema * Fix spelling * Fix package name * Fix read replica e2e * Add job templates for rotation, creation, saving, and correction * Update config.go to decode k8s object * Update sample.yaml for index operator * Use job template from cfg * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 584d1f0 according to the output from Gofumpt and Prettier. Details: #2444 * Fix tagalign * Fix config test * Fix config test * Disable read replica e2e for now --------- Signed-off-by: Yusuke Kadowaki <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Hiroto Funakoshi <[email protected]> * add inner product distance type for ngt (#2454) Signed-off-by: kpango <[email protected]> * Fix e2e for read replica and add e2e for index operator (#2455) * Fix read replica e2e * Update default image list in action.yaml * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 6cdac9f according to the output from Gofumpt and Prettier. Details: #2455 --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Add unit tests for index operator (#2460) * Add prototype tests * Refactor * Fix not to use kubeconfig * 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]> * Bugfix recreate benchmark job when operator reboot (#2463) * 🐛 Fix recreate benchmark job already runnnig when operator rebooted Signed-off-by: vankichi <[email protected]> * 🐛 Fix benchmarkJobReconcile status handling Signed-off-by: vankichi <[email protected]> * ✅ Fix test Signed-off-by: vankichi <[email protected]> * ♻️ Update k8s dir Signed-off-by: vankichi <[email protected]> * ♻️ Fix Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]> * Refactor k8s types (#2462) * Refactor types * Refactor hdf5_test.go * Format * Refactor * add extra flags for NGT build phase (#2467) * Fix workflow trigger for backport pr creation (#2471) * Automatically add backport main label for release-pr (#2473) * feat: automatically add backport main label for release-pr Signed-off-by: Hiroto Funakoshi <[email protected]> * fix: deleted unnecessary quotation Signed-off-by: Hiroto Funakoshi <[email protected]> --------- Signed-off-by: Hiroto Funakoshi <[email protected]> * update deps (#2468) * update deps Signed-off-by: kpango <[email protected]> * fix server_test.go due to the grpc-go updates Signed-off-by: kpango <[email protected]> --------- Signed-off-by: kpango <[email protected]> * Update README.md (#2479) Signed-off-by: Yusuke Kato <[email protected]> * Implement client metrics interceptor for continuous benchmark job (#2477) * ♻️ Mount benchmark-operator-config to vald-benchmark-job Pod Signed-off-by: vankichi <[email protected]> * 📈 add framework for send gRPC client metrics Signed-off-by: vankichi <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in a532b7d according to the output from Gofumpt and Prettier. Details: #2477 * 📈 Add client metric interceptor Signed-off-by: vankichi <[email protected]> * ♻️ Change vbor chart for apply general job configuration Signed-off-by: vankichi <[email protected]> * Update pkg/tools/benchmark/job/usecase/benchmarkd.go Co-authored-by: Hiroto Funakoshi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> * 🐛 Fix build error and add comment Signed-off-by: vankichi <[email protected]> * ♻️ Fix format Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Hiroto Funakoshi <[email protected]> * implement ngt-rs and its unit test and add GitHub Actions workflows (#2478) * implement test * update rust dependencies * fix * make format * add Github Actions workflows * fix * fix * fix * fix * fix * fix * fix * fix * fix --------- Co-authored-by: Yusuke Kato <[email protected]> * 📈 Add client metrics panels for continuous benchmark job (#2481) Signed-off-by: vankichi <[email protected]> * Add rust versions (#2482) * add rust versions * fix * add rust version * add rust-toolchain.toml * make format * Update continuous benchmark docs (#2485) * 📝 Update continous benchmark docs Signed-off-by: vankichi <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in e3ab1d2 according to the output from Gofumpt and Prettier. Details: #2485 * Update docs/performance/continuous-benchmark.md Signed-off-by: Kiichiro YUKAWA <[email protected]> * 📝 Fix Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * update NGT version (#2484) * fix sed line (#2488) * 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2487) Signed-off-by: Vdaas CI <[email protected]> Co-authored-by: Hiroto Funakoshi <[email protected]> * Add efficient search logic for large top-k users (#2491) * add efficient search logic for large top-k users Signed-off-by: kpango <[email protected]> * fix bug Signed-off-by: kpango <[email protected]> --------- Signed-off-by: kpango <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> Signed-off-by: Vdaas CI <[email protected]> Signed-off-by: kpango <[email protected]> Signed-off-by: Yusuke Kato <[email protected]> Signed-off-by: vankichi <[email protected]> Signed-off-by: Kiichiro YUKAWA <[email protected]> Signed-off-by: Yusuke Kadowaki <[email protected]> Signed-off-by: aknishid <[email protected]> Signed-off-by: Yamada Takuya <[email protected]> Signed-off-by: aknishid <[email protected]> Signed-off-by: Hrichik Mazumder <[email protected]> Signed-off-by: Hiroto Funakoshi <[email protected]> Co-authored-by: vdaas-ci <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kadowaki <[email protected]> Co-authored-by: Yusuke Kato <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: taisho <[email protected]> Co-authored-by: taisuou <[email protected]> Co-authored-by: aknishid <[email protected]> Co-authored-by: takuyaymd <[email protected]> Co-authored-by: takuyyam <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Hrichik Mazumder <[email protected]>
kpango
added a commit
that referenced
this pull request
Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <[email protected]>
kpango
added a commit
that referenced
this pull request
Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <[email protected]>
kpango
added a commit
that referenced
this pull request
Aug 8, 2024
fix: git add chart directory for release (#2356) (#2357) [patch] release v1.7.11 (#2358) :bookmark: :robot: Release v1.7.11 (#2360) Change docker scan timeout longer (#2363) (#2364) refactor code using golangci-lint (#2362) (#2365) Create SECURITY.md (#2367) (#2368) add commit hash build image (#2359) (#2371) update docker build target platform selection rules (#2370) (#2374) Make agent export index metrics to Pod k8s resource (#2319) (#2372) backport ci deps others (#2386) Update workflow to release readreplica chart (#2383) (#2387) :green_heart: :recycle: Add Con-Bench helm chart to the Vald charts (#2388) (#2389) Delete unnecessary code for mirror (#2366) (#2391) change JP logo to EN logo (#2369) (#2392) Add rotate-all option to rotator (#2305) (#2393) fix: build error of internal kvs test (#2396) (#2398) Resolve kvs already closed before last saving (#2390) (#2394) :robot: Update license headers / Format Go codes and YAML files (#2397) (#2400) create continous benchmark doc (#2352) (#2395) fix: disable protobuf dispatch for client (#2401) (#2403) update deps (#2404) (#2405) [patch] release v1.7.12 (#2406) :bookmark: :robot: Release v1.7.12 (#2408) :pencil: Fix typo of file name (#2413) (#2415) Fix agent-faiss build failed (#2418) (#2419) Add tests for index information export (#2412) (#2414) Fix the logic to determine docker image (#2410) (#2420) Update build rule for nightly image (#2421) (#2422) Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423) (#2425) Add `index-operator` template implementation (#2375) (#2424) fix: typo of execution rule (#2426) (#2427) Backport Flush API (#2434) update deps & add validation for Flush API when agent is Read Only (#2433) (#2436) docs: add hrichiksite as a contributor for doc (#2441) (#2442) fix: bugfix version update for docker build (#2445) (#2446) Fix index job logic to pass DNS A record (#2438) (#2448) Added snapshot timestamp annotations to read replica agent (#2428) (#2443) Fix operator-sdk version (#2447) (#2449) add file name lint (#2417) (#2450) fix: add extra option for ci-container build (#2451) (#2452) Add base of benchmark operator dashboard (#2430) (#2453) Implement index operator logic for read replica rotation (#2444) (#2456) add inner product distance type for ngt (#2454) (#2458) Fix e2e for read replica and add e2e for index operator (#2455) (#2459) Add unit tests for index operator (#2460) (#2461) Bugfix recreate benchmark job when operator reboot (#2463) (#2464) Refactor k8s types (#2462) (#2465) :robot: Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457) (#2469) Fix workflow trigger for backport pr creation (#2471) (#2472) Automatically add backport main label for release-pr (#2473) (#2475) update deps (#2468) (#2476) Implement client metrics interceptor for continuous benchmark job (#2477) (#2480) :chart_with_upwards_trend: Add client metrics panels for continuous benchmark job (#2481) (#2483) Update continuous benchmark docs (#2485) (#2486) Sync release/v1.7 to main (#2495) add read replica and rotator docs (#2497) (#2499) add reviewer guideline (#2507) (#2508) update large top-K ratio handling logic (#2509) (#2511) Change default image tag from latest to nightly (#2516) (#2518) Bugfix that caused an error when argument has 3 or more nil arguments (#2517) (#2520) add faiss in values.yaml & valdrelease.yaml (#2514) (#2519) capitalize faq (#2512) (#2522) Backport docs updates to release/v1.7 (#2521) [CI] Add workflow to synchronize ubuntu base image (#2526) (#2527) fix: update schedule (#2528) (#2530) refactor index manager service add index service API to expose index informations (#2525) (#2532) fix conflict bug (#2537) fix: make format (#2534) (#2540) Backport PR #2542, #2538 to release/v1.7 (#2543) fix: add checkout option (#2545) (#2546) Implement ngt Statistics API (#2539) (#2547) Add workflow to check git conflict for backport PR (#2548) (#2550) [create-pull-request] automated change (#2552) (#2556) Update dependencies, C++ standard, and improve Dockerfiles for better build systems and localization (#2549) (#2557) Backport #2559 (#2560) [BUGFIX] index correction process (#2565) (#2566) change external docker image reference to ghcr.io registry (#2567) (#2568) [patch] Release v1.7.13 (#2569) :bookmark: :robot: Release v1.7.13 (#2570) add HTTP2 support for http.Client and Vald HTTP Server (#2572) (#2575) Signed-off-by: kpango <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the design was such that users could connect to mirror components, so an interface was provided in vald.go. However, the design has been changed to allow users to register connection information using the custom resource method, so the interface definition is no longer needed. I forgot to delete it, so I removed it in this PR.
Related Issue
Versions
Checklist
Special notes for your reviewer