Add implementation for create index job #2223

hlts2 · 2023-10-31T03:10:35Z

Description:

I added a component to execute the createIndex requests to agents.
This component will run as a k8s job in the future.

Related Issue:

Versions:

Go Version: 1.21.3
Docker Version: 20.10.8
Kubernetes Version: v1.28.2
NGT Version: 2.1.3

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

Signed-off-by: hlts2 <[email protected]>

cloudflare-workers-and-pages · 2023-10-31T03:10:54Z

Deploying with Cloudflare Pages

Latest commit:	`c188e66`
Status:	✅ Deploy successful!
Preview URL:	https://791326cb.vald.pages.dev
Branch Preview URL:	https://feature-index-job-create.vald.pages.dev

View logs

vdaas-ci · 2023-10-31T03:11:09Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2023-10-31T03:11:13Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions · 2023-10-31T03:11:20Z

dockers/index/job/creation/Dockerfile

+ENV APP_NAME index-creation
+
+# skipcq: DOK-DL3008
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

Signed-off-by: hlts2 <[email protected]>

internal/config/index_creator.go

pkg/index/job/creation/service/indexer.go

pkg/index/job/creation/service/options.go

pkg/index/job/creation/usecase/creation.go

internal/config/index_creator.go

pkg/index/job/creation/service/indexer.go

pkg/index/job/creation/service/options.go

pkg/index/job/creation/usecase/creation.go

Signed-off-by: hlts2 <[email protected]>

pkg/index/job/creation/usecase/creation.go

codecov · 2023-10-31T03:23:37Z

Codecov Report

Attention: 287 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
internal/config/index_creation.go	`0.00% <0.00%> (ø)`
pkg/index/job/creation/service/options.go	`7.40% <7.40%> (ø)`
pkg/index/job/creation/config/config.go	`0.00% <0.00%> (ø)`
pkg/index/job/creation/service/indexer.go	`34.04% <34.04%> (ø)`
pkg/index/job/creation/usecase/creation.go	`0.00% <0.00%> (ø)`

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Signed-off-by: hlts2 <[email protected]>

This reverts commit e59ded2.

* feat: add index creation job implementation Signed-off-by: hlts2 <[email protected]> * feat: make format Signed-off-by: hlts2 <[email protected]> * fix: deepsource warning Signed-off-by: hlts2 <[email protected]> * fix: reviewdog warning and rename config file Signed-off-by: hlts2 <[email protected]> * feat: add mock for testing Signed-off-by: hlts2 <[email protected]> * feat: generate test code Signed-off-by: hlts2 <[email protected]> * fix: make format Signed-off-by: hlts2 <[email protected]> * feat: add test for indexing service Signed-off-by: hlts2 <[email protected]> * fix: improve grpc status handling Signed-off-by: hlts2 <[email protected]> * fix: docker build error Signed-off-by: hlts2 <[email protected]> * fix: deepsource warning Signed-off-by: hlts2 <[email protected]> * fix: start discoverer client before the logic is executed Signed-off-by: hlts2 <[email protected]> * fix: log message and sample data Signed-off-by: hlts2 <[email protected]> * fix: generate test and format Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]>

hlts2 added 2 commits October 31, 2023 12:09

feat: add index creation job implementation

51550ba

Signed-off-by: hlts2 <[email protected]>

Merge branch 'main' into feature/index-job/create

b1c2e50

github-actions bot added team/sre SRE team area/internal type/ci area/makefile size/XL type/feature New feature labels Oct 31, 2023

github-actions bot reviewed Oct 31, 2023

View reviewed changes

feat: make format

c43d7c3

Signed-off-by: hlts2 <[email protected]>

github-actions bot added the priority/medium label Oct 31, 2023

github-actions bot reviewed Oct 31, 2023

View reviewed changes

fix: deepsource warning

381b0b7

Signed-off-by: hlts2 <[email protected]>

hlts2 self-assigned this Oct 31, 2023

hlts2 marked this pull request as draft October 31, 2023 03:23

github-actions bot reviewed Oct 31, 2023

View reviewed changes

pkg/index/job/creation/usecase/creation.go Show resolved Hide resolved

pkg/index/job/creation/usecase/creation.go Outdated Show resolved Hide resolved

pkg/index/job/creation/usecase/creation.go Outdated Show resolved Hide resolved

hlts2 added 5 commits October 31, 2023 12:39

fix: reviewdog warning and rename config file

ac9c364

Signed-off-by: hlts2 <[email protected]>

feat: add mock for testing

4594d4a

Signed-off-by: hlts2 <[email protected]>

feat: generate test code

74eb4e4

Signed-off-by: hlts2 <[email protected]>

fix: make format

6834dc7

Signed-off-by: hlts2 <[email protected]>

feat: add test for indexing service

8b23674

Signed-off-by: hlts2 <[email protected]>

github-actions bot added team/set SET team size/XXL and removed size/XL labels Nov 1, 2023

fix: improve grpc status handling

7f69865

Signed-off-by: hlts2 <[email protected]>

hlts2 marked this pull request as ready for review November 1, 2023 05:42

hlts2 added 5 commits November 1, 2023 14:49

fix: docker build error

9d2646a

Signed-off-by: hlts2 <[email protected]>

fix: deepsource warning

b950fc8

Signed-off-by: hlts2 <[email protected]>

fix: start discoverer client before the logic is executed

25173a5

Signed-off-by: hlts2 <[email protected]>

fix: log message and sample data

cc2be12

Signed-off-by: hlts2 <[email protected]>

fix: generate test and format

51c8d56

Signed-off-by: hlts2 <[email protected]>

hlts2 requested review from a team, kmrmt, datelier and ykadowak and removed request for a team November 2, 2023 03:15

ykadowak approved these changes Nov 2, 2023

View reviewed changes

hlts2 changed the title ~~Add implementation for index creation job~~ Add implementation for create index job Nov 6, 2023

Merge branch 'main' into feature/index-job/create

c188e66

datelier approved these changes Nov 6, 2023

View reviewed changes

datelier merged commit e59ded2 into main Nov 6, 2023
89 of 91 checks passed

datelier deleted the feature/index-job/create branch November 6, 2023 07:06

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

b719bca

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

83cb1ec

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

6a69160

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

e69eccc

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

d995c9c

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

7e309b4

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

f9acd20

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

2f1c1b1

This reverts commit e59ded2.

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Add implementation for create index job (#2223)"

ddbb0fb

This reverts commit e59ded2.

vankichi mentioned this pull request Dec 4, 2023

[patch] release v1.7.9 #2257

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation for create index job #2223

Add implementation for create index job #2223

hlts2 commented Oct 31, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 31, 2023 •

edited

Loading

vdaas-ci commented Oct 31, 2023

vdaas-ci commented Oct 31, 2023

github-actions bot Oct 31, 2023

codecov bot commented Oct 31, 2023 •

edited

Loading

Add implementation for create index job #2223

Add implementation for create index job #2223

Conversation

hlts2 commented Oct 31, 2023 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

cloudflare-workers-and-pages bot commented Oct 31, 2023 • edited Loading

Deploying with Cloudflare Pages

vdaas-ci commented Oct 31, 2023

vdaas-ci commented Oct 31, 2023

github-actions bot Oct 31, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 31, 2023 • edited Loading

Codecov Report

hlts2 commented Oct 31, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 31, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading