Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add job to check format difference #2214

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add job to check format difference #2214

merged 3 commits into from
Oct 23, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Oct 18, 2023 •
edited
Loading

Description:

This PR contains the following changes

  • Add a job to check format differences in order to notice if formatting is forgotten before the merge.
  • Fix helm-docs installation URL because ci-container builds fail

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04fcda7
Status: ✅  Deploy successful!
Preview URL: https://a2bc51a0.vald.pages.dev
Branch Preview URL: https://fix-ci-format-job.vald.pages.dev

View logs

@hlts2
Copy link
Contributor Author

hlts2 commented Oct 18, 2023 •
edited
Loading

📝 The format job is failing, but this is due to an outdated ci-container image(nightly) in the main branch.
When this PR is merged, it will succeed 🙏
👉　https://github.com/vdaas/vald/actions/runs/6559697186/job/17815790205?pr=2214

@hlts2 hlts2 self-assigned this Oct 18, 2023
@hlts2 hlts2 requested review from a team, kmrmt and vankichi and removed request for a team October 18, 2023 10:49
vankichi
vankichi approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 72a8582 into main Oct 23, 2023
23 of 24 checks passed
@vankichi vankichi deleted the fix/ci/format-job branch October 23, 2023 04:42
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
ddd4883 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
2db0d65 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
d8781b1 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
fe0246d 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
4cfb6dd 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
7f82048 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
0353051 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
978b452 
This reverts commit 72a8582.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add job to check format difference (#2214)"
82fea29 
This reverts commit 72a8582.
@vankichi vankichi mentioned this pull request Dec 4, 2023
Merged
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@hlts2 @kmrmt
Add job to check format difference (#2214)
ba4b198 
* feat: add job to check format diff

Signed-off-by: hlts2 <[email protected]>

* fix: helm-docs installation url

Signed-off-by: hlts2 <[email protected]>

* fix: job execution rule

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmrmt kmrmt kmrmt approved these changes

@vankichi vankichi vankichi approved these changes

Assignees

@hlts2 hlts2

Labels
area/makefile priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kmrmt @vankichi