Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified apiversion capabilities check #2149

Merged
merged 4 commits into from
Aug 7, 2023
Merged

modified apiversion capabilities check #2149

merged 4 commits into from
Aug 7, 2023

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Aug 3, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 3, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 315fe69
Status: ✅  Deploy successful!
Preview URL: https://7765f937.vald.pages.dev
Branch Preview URL: https://feature-helm-check-apiversio.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

hlts2
hlts2 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@ykadowak ykadowak merged commit 0ccbb3b into main Aug 7, 2023
23 checks passed
@ykadowak ykadowak deleted the feature/helm/check-apiversion branch August 7, 2023 06:59
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "modified apiversion capabilities check (#2149)"
ca8d337 
This reverts commit 0ccbb3b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "modified apiversion capabilities check (#2149)"
f018015 
This reverts commit 0ccbb3b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "modified apiversion capabilities check (#2149)"
a38c1e4 
This reverts commit 0ccbb3b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "modified apiversion capabilities check (#2149)"
63fb037 
This reverts commit 0ccbb3b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@ykadowak ykadowak ykadowak approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/helm priority/medium size/S team/sre SRE team type/ci type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datelier @vdaas-ci @hlts2 @ykadowak