Implement StreamListObject and its tests #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d21c1af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0dff87c.vald.pages.dev |
| Branch Preview URL: | https://feature-stream-list-object.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
+ Coverage 31.14% 31.18% +0.04%
==========================================
Files 339 339
Lines 32834 32920 +86
==========================================
+ Hits 10225 10265 +40
- Misses 22157 22200 +43
- Partials 452 455 +3
☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ykadowak
force-pushed
the
feature/stream-list-object
branch
from
004fb04
to
1952b5c
Compare
ykadowak
changed the title
ykadowak
requested review from
a team,
kevindiu and
datelier
and removed request for
a team
datelier
previously approved these changes
Aug 1, 2023
kevindiu
reviewed
Aug 1, 2023
kevindiu
reviewed
Aug 1, 2023
kevindiu
previously approved these changes
Aug 2, 2023
kevindiu
reviewed
Aug 3, 2023
Comment on lines
261
to
268
| for _, e := range errs { | ||
| st, msg, err := status.ParseError(e, codes.Internal, "failed to parse StreamListObject final gRPC error response") | ||
| if span != nil { | ||
| span.RecordError(err) | ||
| span.SetAttributes(trace.FromGRPCStatus(st.Code(), msg)...) | ||
| span.SetStatus(trace.StatusError, msg) | ||
| } | ||
| } |
There was a problem hiding this comment.
seems we can rewrite it like
Suggested change
| for _, e := range errs { | |
| st, msg, err := status.ParseError(e, codes.Internal, "failed to parse StreamListObject final gRPC error response") | |
| if span != nil { | |
| span.RecordError(err) | |
| span.SetAttributes(trace.FromGRPCStatus(st.Code(), msg)...) | |
| span.SetStatus(trace.StatusError, msg) | |
| } | |
| } | |
| if span != nil { | |
| for _, e := range errs { | |
| st, msg, err := status.ParseError(e, codes.Internal, "failed to parse StreamListObject final gRPC error response") | |
| span.RecordError(err) | |
| span.SetAttributes(trace.FromGRPCStatus(st.Code(), msg)...) | |
| span.SetStatus(trace.StatusError, msg) | |
| } | |
| } |
because this block of logic only effective when span is not nil.
kevindiu
approved these changes
Aug 3, 2023
datelier
approved these changes
Aug 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements
StreamListObjectrpc.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: