Make internal/cache generic #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
2141337
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3069a574.vald.pages.dev |
| Branch Preview URL: | https://feature-internal-gachev2.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
ykadowak
changed the title
ykadowak
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
- Coverage 30.65% 29.93% -0.73%
==========================================
Files 347 369 +22
Lines 34255 35095 +840
==========================================
+ Hits 10501 10505 +4
- Misses 23276 24107 +831
- Partials 478 483 +5
☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ykadowak
force-pushed
the
feature/internal/gachev2
branch
from
bb93bb6
to
60229ed
Compare
ykadowak
changed the title
ykadowak
requested review from
a team,
vankichi and
hlts2
and removed request for
a team
Profile Report
|
ykadowak
force-pushed
the
feature/internal/gachev2
branch
from
342f81d
to
e61ea5e
Compare
vankichi
approved these changes
Jul 7, 2023
hlts2
approved these changes
Jul 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
gacheto v2internal/cachegenericdialer.goto be compatible with the genericinternal/cacheRelated Issue:
Versions:
Checklist:
Special notes for your reviewer: