use GOBIN instead of GOPATH/bin

[kpango]

Description:

SSIA

Related Issue:

Versions:

• Go Version: 1.20.5
• Docker Version: 20.10.8
• Kubernetes Version: v1.27.3
• NGT Version: 2.0.13

Checklist:

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	c6d27df
Status:	✅  Deploy successful!
Preview URL:	https://fa132438.vald.pages.dev
Branch Preview URL:	https://refactor-makefile-use-gobin.vald.pages.dev

View logs

[ykadowak]

It should be checked if GOBIN is set at first and if not, fallback to GOPATH/bin?

[kpango]

@ykadowak Indeed, I think it is a good idea to backport to GOPATH/bin when "go env GOBIN" is empty.
However, since GOPATH is also obtained from "go env GOPATH", I think it is a rare case that only "go env GOBIN" is missing in the go environment in the initial Install state.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (5a28ee6) 48.63% compared to head (c6d27df) 48.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
+ Coverage   48.63%   48.65%   +0.02%     
==========================================
  Files         171      171              
  Lines        8994     8994              
==========================================
+ Hits         4374     4376       +2     
+ Misses       4496     4495       -1     
+ Partials      124      123       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ykadowak]

@ykadowak Indeed, I think it is a good idea to backport to GOPATH/bin when "go env GOBIN" is empty. However, since GOPATH is also obtained from "go env GOPATH", I think it is a rare case that only "go env GOBIN" is missing in the go environment in the initial Install state.

Thanks for adding it.

I checked go env GOBIN is empty in the initial state in both brew install go on Mac and the official devcontainer go image. Probably something has changed.