Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search algorithm benchmark and update search aggregation algo #2044

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 1, 2023

Description:

This PR made corrections to Vald's search result aggregation algorithm and added four new algorithms.

  1. ConcurrentQueue
  2. SortSlice
  3. SortPoolSlice
  4. PairingHeap

The VTPool has also been enabled, as it had been disabled.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9bdaff
Status: ✅  Deploy successful!
Preview URL: https://a6f2e3fa.vald.pages.dev
Branch Preview URL: https://refactor-lbgw-search-aggrega.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 1, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 9.52% and project coverage change: -0.07 ⚠️

Comparison is base (96df080) 29.99% compared to head (e9bdaff) 29.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   29.99%   29.92%   -0.07%     
==========================================
  Files         366      369       +3     
  Lines       34797    35079     +282     
==========================================
+ Hits        10436    10499      +63     
- Misses      23878    24099     +221     
+ Partials      483      481       -2     
Impacted Files Coverage Δ
internal/k8s/metrics/node/node.go 0.00% <0.00%> (ø)
internal/k8s/metrics/pod/pod.go 0.00% <0.00%> (ø)
internal/k8s/node/node.go 0.00% <0.00%> (ø)
internal/k8s/pod/pod.go 0.00% <0.00%> (ø)
internal/k8s/reconciler.go 0.00% <ø> (ø)
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/pairing_heap.go 92.30% <92.30%> (ø)
internal/file/file.go 12.69% <100.00%> (+0.69%) ⬆️
internal/rand/rand.go 83.87% <100.00%> (+1.11%) ⬆️
... and 1 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the refactor/lbgw/search-aggregation-algos branch 3 times, most recently from 8cfd61d to 27db649 Compare June 1, 2023 07:28
pkg/gateway/lb/handler/grpc/aggregation.go Show resolved Hide resolved
pkg/gateway/lb/handler/grpc/aggregation.go Show resolved Hide resolved
internal/test/data/strings/strings.go Show resolved Hide resolved
internal/rand/rand.go Show resolved Hide resolved
pkg/gateway/lb/handler/grpc/aggregation.go Show resolved Hide resolved
pkg/gateway/lb/handler/grpc/aggregation.go Show resolved Hide resolved
pkg/gateway/lb/handler/grpc/aggregation.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

@kpango kpango force-pushed the refactor/lbgw/search-aggregation-algos branch from 8030f99 to 7bca085 Compare June 7, 2023 06:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

vankichi
vankichi previously approved these changes Jun 8, 2023
ykadowak
ykadowak previously approved these changes Jun 8, 2023
@kpango kpango merged commit 3d70f81 into main Jun 9, 2023
@kpango kpango deleted the refactor/lbgw/search-aggregation-algos branch June 9, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants