Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] remove sudo from kubectl/install make command and small refactor around os/arch #2037

Merged
merged 1 commit into from
May 24, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 23, 2023

Description:

Fixed CI Container build failure due to use of sudo in kubectl/install in the Makefile.
And refactored redundant OS/Arch switches.

Related Issue:

Versions:

  • Go Version: 1.20.4
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.27.1
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the bugfix/tools/remove-sudo-from-kubectl-install branch from c465e22 to eda6ddc Compare May 23, 2023 10:01
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: abab3f1
Status: ✅  Deploy successful!
Preview URL: https://dc4af1b7.vald.pages.dev
Branch Preview URL: https://bugfix-tools-remove-sudo-fro.vald.pages.dev

View logs

@kpango kpango changed the title [Bugfix] remove sudo from kubectl and small refactor around os/arch [Bugfix] remove sudo from kubectl/install make command and small refactor around os/arch May 23, 2023
@kpango kpango requested review from a team, vankichi and hlts2 and removed request for a team May 23, 2023 10:04
@kpango kpango force-pushed the bugfix/tools/remove-sudo-from-kubectl-install branch from eda6ddc to 489a010 Compare May 23, 2023 10:11
@kpango kpango force-pushed the bugfix/tools/remove-sudo-from-kubectl-install branch from 489a010 to a5b09de Compare May 23, 2023 10:17
@kpango kpango force-pushed the bugfix/tools/remove-sudo-from-kubectl-install branch from a5b09de to 924bb17 Compare May 23, 2023 10:36
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Copy link
Contributor

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. Didn't realize it was failing.

I think we should stop DeepSource: Test coverage for now so that we realize some tests are actually failing.

@kpango
Copy link
Collaborator Author

kpango commented May 24, 2023

To disabling the DeepSource-TestCoverage, we have to
edit https://github.com/vdaas/vald/blob/main/.deepsource.toml#L70.
Is it okay to separate it from this PR?

@ykadowak
Copy link
Contributor

To disabling the DeepSource-TestCoverage, we have to edit https://github.com/vdaas/vald/blob/main/.deepsource.toml#L70. Is it okay to separate it from this PR?

👍

@kpango kpango merged commit 4b86756 into main May 24, 2023
@kpango kpango deleted the bugfix/tools/remove-sudo-from-kubectl-install branch May 24, 2023 02:31
@kpango
Copy link
Collaborator Author

kpango commented May 24, 2023

@ykadowak #2038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants