Update RoundTrip retry condition #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
vankichi
requested review from
a team,
kpango and
ykadowak
and removed request for
a team
Deploying with
|
| Latest commit: |
077bf60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72f12191.vald.pages.dev |
| Branch Preview URL: | https://refactor-internal-update-rou.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
team/set
vankichi
added
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-profiling
and removed
type/refactoring
size/M
labels
Profile Report
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
+ Coverage 29.41% 29.42% +0.01%
==========================================
Files 366 366
Lines 34625 34625
==========================================
+ Hits 10186 10190 +4
+ Misses 24013 24009 -4
Partials 426 426
☔ View full report in Codecov by Sentry. |
hlts2
approved these changes
May 22, 2023
ykadowak
approved these changes
May 22, 2023
vankichi
deleted the
refactor/internal/update-roundtrip-retryable-condition
branch
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have updated the round trip retry condition, which removed MovePermanently from the retry condition.
Because it repeats the round trip with the original URL even though the redirect occurs.
We don't need to do a round trip if a redirect occurs because it will lead to the redirect destination.
Related Issue:
None
Versions:
Checklist:
Special notes for your reviewer: