Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix lint. #2

Merged
merged 1 commit into from
Sep 10, 2019
Merged

🚨 Fix lint. #2

merged 1 commit into from
Sep 10, 2019

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Sep 9, 2019

I fixed some irregular patterns in Makefile.

@rinx rinx requested a review from kpango September 9, 2019 12:23
@rinx rinx self-assigned this Sep 9, 2019
@kpango
Copy link
Collaborator

kpango commented Sep 10, 2019

LGTM thanks! @rinx

@kpango kpango merged commit bc94baf into master Sep 10, 2019
@kpango kpango deleted the fix/Makefile-lint branch September 10, 2019 00:44
rinx added a commit that referenced this pull request Sep 8, 2020
# This is the 1st commit message:

:wrench: pass CXXFLAGS to CGO_CXXFLAGS...

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #2:

:construction: wip

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #3:

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #4:

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <[email protected]>
vdaas-ci pushed a commit that referenced this pull request Sep 8, 2020
# This is the 1st commit message:

:wrench: pass CXXFLAGS to CGO_CXXFLAGS...

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #2:

:construction: wip

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #3:

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #4:

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <[email protected]>
kpango pushed a commit that referenced this pull request Sep 8, 2020
* # This is a combination of 4 commits.
# This is the 1st commit message:

:wrench: pass CXXFLAGS to CGO_CXXFLAGS...

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #2:

:construction: wip

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #3:

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

# This is the commit message #4:

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

* :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

:construction: wip

Signed-off-by: Rintaro Okamura <[email protected]>

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <[email protected]>

:fire: remove useless line

Signed-off-by: Rintaro Okamura <[email protected]>
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 17, 2022
kpango added a commit that referenced this pull request Apr 5, 2023
vankichi pushed a commit that referenced this pull request Apr 5, 2023
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
@coderabbitai coderabbitai bot mentioned this pull request Sep 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants