Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nvimlog #1994

Merged
merged 1 commit into from
Apr 3, 2023
Merged

remove nvimlog #1994

merged 1 commit into from
Apr 3, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 3, 2023

Description:

@kevindiu added nvimlog file
It's unnecessary file for vald.

So I deleted it and add nvimlog to gitignore

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@kpango
remove nvimlog
7b2d8b9 
Signed-off-by: kpango <[email protected]>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango merged commit 94203ca into main Apr 3, 2023
@kpango kpango deleted the refactor/remove-nvimlog branch April 3, 2023 08:43
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu approved these changes

@hlts2 hlts2 hlts2 approved these changes

Assignees
No one assigned
Labels
priority/low size/S type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kevindiu @hlts2