Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-implemented test #1952

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Remove non-implemented test #1952

merged 1 commit into from
Feb 27, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Feb 13, 2023

Signed-off-by: kevindiu [email protected]

Description:

This PR remove empty testing stubs, to avoid testing template changes affecting the implementation of empty testing stubs.
The testing stubs which are already implemented will not be removed or updated in this PR, even if it is generated by the legacy testing template.

Since this changes causing a lots of testing file changes, it is very hard to review changes one by one.
Please review by looking at the code coverage changes on
https://app.codecov.io/gh/vdaas/vald/pull/1952

This PR has almost no affect on the code coverage changes, meaning that this PR only remove the empty testing stubs, without removing the implemented tests.

Related Issue:

Versions:

  • Go Version: 1.20
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 50.23% // Head: 29.74% // Decreases project coverage by -20.49% ⚠️

Coverage data is based on head (a5dfbeb) compared to base (97eed29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1952       +/-   ##
===========================================
- Coverage   50.23%   29.74%   -20.49%     
===========================================
  Files         231      366      +135     
  Lines       13464    34101    +20637     
===========================================
+ Hits         6764    10145     +3381     
- Misses       6499    23549    +17050     
- Partials      201      407      +206     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/gateway/filter/main.go 0.00% <ø> (ø)
cmd/gateway/lb/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
cmd/tools/cli/vdctl/main.go 0.00% <ø> (ø)
internal/observability/metrics/info/info.go 0.00% <0.00%> (-100.00%) ⬇️
internal/errors/ngt.go 70.00% <0.00%> (-19.66%) ⬇️
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevindiu kevindiu changed the title [WIP] Remove non-implemented test Remove non-implemented test Feb 20, 2023
@kevindiu kevindiu marked this pull request as ready for review February 20, 2023 23:54
@kevindiu kevindiu merged commit 0f6c1e6 into main Feb 27, 2023
@kevindiu kevindiu deleted the refactor/remove-empty-test-stub branch February 27, 2023 05:52
@kpango kpango mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants