Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error on dump context workflow #1936

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jan 27, 2023

Signed-off-by: kevindiu [email protected]

Description:

This PR fixes the following error on dump context to log CI.
e.g. https://github.com/vdaas/vald/actions/runs/4021682715/jobs/6910767092

line 237: syntax error near unexpected token `('

related issue: actions/runner#1656

Related Issue:

Versions:

  • Go Version: 1.19.5
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b704b15
Status: ✅  Deploy successful!
Preview URL: https://01f69efc.vald.pages.dev
Branch Preview URL: https://ci-workflow-fix-dump-context.vald.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 50.23% // Head: 30.02% // Decreases project coverage by -20.22% ⚠️

Coverage data is based on head (b704b15) compared to base (97eed29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1936       +/-   ##
===========================================
- Coverage   50.23%   30.02%   -20.22%     
===========================================
  Files         231      366      +135     
  Lines       13464    33704    +20240     
===========================================
+ Hits         6764    10119     +3355     
- Misses       6499    23176    +16677     
- Partials      201      409      +208     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/gateway/filter/main.go 0.00% <ø> (ø)
cmd/gateway/lb/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
cmd/tools/cli/vdctl/main.go 0.00% <ø> (ø)
internal/observability/metrics/info/info.go 0.00% <0.00%> (-100.00%) ⬇️
internal/errors/vald.go 50.00% <0.00%> (-16.67%) ⬇️
... and 261 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevindiu kevindiu changed the title [WIP] Fix syntax error on dump context workflow Fix syntax error on dump context workflow Jan 27, 2023
@kevindiu kevindiu marked this pull request as ready for review January 27, 2023 06:30
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu merged commit 589fe4e into main Jan 30, 2023
@kevindiu kevindiu deleted the ci/workflow/fix-dump-context-syntax-error branch January 30, 2023 01:58
This was referenced Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants