Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deepsource: [CRT-D0001] append possibly assigns to a wrong variable #1866

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Nov 22, 2022

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 50.23% // Head: 30.53% // Decreases project coverage by -19.69% ⚠️

Coverage data is based on head (a231815) compared to base (97eed29).
Patch coverage: 34.01% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1866       +/-   ##
===========================================
- Coverage   50.23%   30.53%   -19.70%     
===========================================
  Files         231      367      +136     
  Lines       13464    33829    +20365     
===========================================
+ Hits         6764    10331     +3567     
- Misses       6499    23086    +16587     
- Partials      201      412      +211     
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
...ck/benchmark/internal/starter/gateway/vald/vald.go 0.00% <0.00%> (ø)
... and 273 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a231815
Status: ✅  Deploy successful!
Preview URL: https://de0f3d91.vald.pages.dev
Branch Preview URL: https://refactoring-crt-d0001-append.vald.pages.dev

View logs

@vankichi vankichi merged commit 44bf9fb into main Nov 22, 2022
@vankichi vankichi deleted the refactoring/CRT-D0001/append-possibly-assigns-to-a-wrong-variable branch November 22, 2022 12:15
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants