Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead link #1807

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Fix dead link #1807

merged 9 commits into from
Oct 19, 2022

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Oct 17, 2022 •
edited
Loading

Description:

This PR fix dead link checked on https://www.deadlinkchecker.com/ on the https://vald.vdaas.org/.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 738350c
Status: ✅  Deploy successful!
Preview URL: https://928084eb.vald.pages.dev
Branch Preview URL: https://documentation-fix-deadlink.vald.pages.dev

View logs

@github-actions github-actions bot added size/L and removed size/S labels Oct 18, 2022
@kevindiu
fix deadlink
08f0a35 
Signed-off-by: kevindiu <[email protected]>
@kevindiu
fix deadlink
fe5d4ec 
Signed-off-by: kevindiu <[email protected]>
@kevindiu
fix comment
a25bcc0 
Signed-off-by: kevindiu <[email protected]>
@kevindiu
fix deadlink
24483b4 
Signed-off-by: kevindiu <[email protected]>
@github-actions github-actions bot added size/S and removed size/S labels Oct 18, 2022
@kevindiu kevindiu changed the title [WIP] Fix deadlink Fix deadlink Oct 18, 2022
@kevindiu kevindiu requested review from vankichi, a team and hlts2 and removed request for a team October 18, 2022 05:51
@kevindiu kevindiu changed the title Fix deadlink Fix dead link Oct 18, 2022
@github-actions github-actions bot added size/S and removed size/S labels Oct 19, 2022
hlts2
hlts2 reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall is good!
I will approve this PR after you fix the feedback content 👍

@kevindiu
remove unused link
826811d 
Signed-off-by: kevindiu <[email protected]>
@github-actions github-actions bot added size/S and removed size/S labels Oct 19, 2022
@kevindiu
fix link
b19d1c8 
Signed-off-by: kevindiu <[email protected]>
@github-actions github-actions bot added size/S and removed size/S labels Oct 19, 2022
@github-actions github-actions bot added size/S and removed size/S labels Oct 19, 2022
@github-actions github-actions bot added size/S and removed size/S labels Oct 19, 2022
hlts2
hlts2 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 1b98802 into main Oct 19, 2022
@kpango kpango deleted the documentation/fix-deadlink branch October 19, 2022 05:18
@kpango kpango mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@vankichi vankichi vankichi approved these changes

@hlts2 hlts2 hlts2 approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevindiu @vdaas-ci @vankichi @hlts2 @kpango