Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dataflow image #1647

Merged
merged 7 commits into from
May 20, 2022
Merged

update dataflow image #1647

merged 7 commits into from
May 20, 2022

Conversation

taisuou
Copy link
Contributor

@taisuou taisuou commented May 11, 2022

Description:

update search,delete,update,upsert data flow image,flowing the design and information volume of insertflow

make draft of each images,then get review based on git pull request.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@taisuou
Copy link
Contributor Author

taisuou commented May 11, 2022

Firstly I made draft of search and delete flow image.
please review those images.

search
search
delete
delete

@taisuou
Copy link
Contributor Author

taisuou commented May 15, 2022

draft update

search
search

delete
delete

update
update

upsert
upsert

@kpango kpango marked this pull request as ready for review May 19, 2022 04:37
@kpango kpango merged commit 4c8fae8 into master May 20, 2022
@kpango kpango deleted the design/dataflow-image branch May 20, 2022 07:37
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants