Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not supported control flag on darwin #1025

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Feb 19, 2021

Signed-off-by: kpango [email protected]

Description:

bugfix internal/net/control on darwin os

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

if ierr != nil {
err = errors.Wrap(err, ierr.Error())
}
if isTCP(network) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
if isTCP(network) is deeply nested (complexity: 18) (nestif)

if ierr != nil {
err = errors.Wrap(err, ierr.Error())
}
if ctrl.keepAlive > 0 && isTCP(network) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
if ctrl.keepAlive > 0 && isTCP(network) is deeply nested (complexity: 6) (nestif)

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #1025 (8687360) into master (27752bd) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.01%     
==========================================
  Files         497      497              
  Lines       28638    28649      +11     
==========================================
- Hits         4252     4251       -1     
- Misses      24117    24128      +11     
- Partials      269      270       +1     
Impacted Files Coverage Δ
internal/net/control/control.go 0.00% <0.00%> (ø)
internal/worker/queue.go 98.33% <0.00%> (-1.67%) ⬇️
internal/worker/worker.go 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf20447...cbbc972. Read the comment docs.

@kevindiu
Copy link
Contributor

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: bugfix/internal-net-control/resolve-undefined-on-darwin

@vdaas-ci vdaas-ci force-pushed the bugfix/internal-net-control/resolve-undefined-on-darwin branch from 5be72b9 to 087c4c9 Compare February 19, 2021 07:11
Signed-off-by: kpango <[email protected]>
…' of https://github.com/vdaas/vald into bugfix/internal-net-control/resolve-undefined-on-darwin
@kpango kpango merged commit 4bf65f8 into master Feb 19, 2021
@kpango kpango deleted the bugfix/internal-net-control/resolve-undefined-on-darwin branch February 19, 2021 07:16
@vdaas-ci vdaas-ci mentioned this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants