Fixed issue#130 #131
Merged
Fixed issue#130 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the TypeError: memoryview: a bytes-like object is required, not 'str' in Python 3.5. May not work or needs to be tested in 2.x .
Changed predecessors_iter to predecessors for Python3.5 compatibility.
vallettea
reviewed
May 14, 2018
koala/serializer.py
Outdated
| value = cell.value | ||
| if isinstance(value, unicode): | ||
| outfile.write(cell.value.encode('utf-8') + "\n") | ||
| #raji-j added |
There was a problem hiding this comment.
you should leave out these comments, they will soon make the code unreadable.
vallettea
reviewed
May 14, 2018
koala/serializer.py
Outdated
| G = DiGraph(data = edges) | ||
|
|
||
| #G = DiGraph(data=edges) | ||
| #raji-j added |
|
why did you closed it ? |
Cleaned up unwanted comments.
|
I am sorry PR is new to me. Shall i re-open the case? I have cleaned up the code. |
|
don't be sorry, I really appreciate that you take time to improve the library. |
|
if you could just increase the version number in setup.py so i can push to pipy |
Fixed issue vallettea#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #130