Update client.go (minio#454)

Signed-off-by: Ivan Anisimov <[email protected]>
vadmeste · Mar 19, 2024 · 332ae57 · 332ae57
1 parent 2f5a124
commit 332ae57
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/keystore/vault/client.go b/internal/keystore/vault/client.go
@@ -83,7 +83,7 @@ func (c *client) AuthenticateWithAppRole(login *AppRole) authFunc {
 			"role_id":   login.ID,
 			"secret_id": login.Secret,
 		})
-		if secret == nil {
+		if secret == nil && err == nil {
 			// The Vault SDK eventually returns no error but also no
 			// secret. In this case have to return a (not very helpful)
 			// error to signal that the authentication failed - for some
@@ -108,7 +108,7 @@ func (c *client) AuthenticateWithK8S(login *Kubernetes) authFunc {
 			"role": login.Role,
 			"jwt":  login.JWT,
 		})
-		if secret == nil {
+		if secret == nil && err == nil {
 			// The Vault SDK eventually returns no error but also no
 			// secret. In this case have to return a (not very helpful)
 			// error to signal that the authentication failed - for some