Skip to content

Commit

Permalink
[fastcall] Introduce a builder pattern for specifying type modifiers
Browse files Browse the repository at this point in the history
- Add a CFunctionBuilder interface to allow adding modifier flags
  to argument types. This will be used to support IDL attributes
  like [EnforceRange], [Clamp], and [AllowShared]. This CL adds
  only the interface, but the actual modifier flags do not exist
  yet as they would not be implemented.
- Remove the internals of the old CFunction type inference and
  implement it on top of CFunctionBuilder.

Bug: chromium:1052746
Change-Id: I09a7cba07105097517a8426a8eeb891393883ac6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686686
Reviewed-by: Toon Verwaest <[email protected]>
Reviewed-by: Maya Lekova <[email protected]>
Commit-Queue: Austin Eng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73024}
  • Loading branch information
austinEng authored and Commit Bot committed Feb 24, 2021
1 parent d98b12d commit db34c5a
Show file tree
Hide file tree
Showing 3 changed files with 255 additions and 142 deletions.
Loading

0 comments on commit db34c5a

Please sign in to comment.