Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples comments #749

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

rmahdav
Copy link
Contributor

@rmahdav rmahdav commented Mar 27, 2024

Shu, I checked the post after it was published and I realized that some comments on examples are long. Even though you asked me to check them before publishing, I forgot. Sorry for sending another PR. Can you please stamp this one as well?

Copy link
Member

@Liedtke Liedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamping with a typo.

@@ -136,7 +137,8 @@ console.log(dates);
// Select the list of blog posts from a blog archive page.
const posts = document.querySelectorAll('li:not(header li)');

// Find out if text content (title) of any blog post includes the `Iteartors` keyword.
// Find out if text content (title) of any blog post includes the `Iteartors`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Find out if text content (title) of any blog post includes the `Iteartors`
// Find out if text content (title) of any blog post includes the `Iterators`

@rmahdav rmahdav merged commit 1e5660c into v8:main Mar 27, 2024
2 checks passed
@rmahdav rmahdav mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants