Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closed issues from triage board #1303

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jun 8, 2022

Committer Notes

This implements part of #1302. See the following example workflow and runs associated with this test configuration.

Example issue with annotated automation: ImportantFederalAgencyTest/remove-project-card-test#12
Successful workflow run creating the issue: https://github.com/ImportantFederalAgencyTest/remove-project-card-test/actions/runs/2463769565
Successful workflow run closing the issue: https://github.com/ImportantFederalAgencyTest/remove-project-card-test/actions/runs/2463777371

IMPORTANT:

  • Did I or did a project owner properly configured the COMMIT_TOKEN secret and it has at least repo:public_repo permissions?
  • Did I or did a project owner configure triage board for this project to have a new done column with automation to correctly move closed issues and merged PRs for the triage board before merging this request?

image

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist added enhancement Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts labels Jun 8, 2022
@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.5 milestone Jun 8, 2022
@aj-stein-nist aj-stein-nist self-assigned this Jun 8, 2022
@aj-stein-nist
Copy link
Contributor Author

Weirdly the owner file reviewer auto-assignment went off @david-waltermire-nist ... weird. Anyway, here you go.

@aj-stein-nist aj-stein-nist force-pushed the 1302-automatically-remove-issues-from-triage-board-when-closed branch 2 times, most recently from 779c7ac to 4cfa121 Compare June 8, 2022 19:25
@aj-stein-nist aj-stein-nist force-pushed the 1302-automatically-remove-issues-from-triage-board-when-closed branch from 4cfa121 to c79f8d8 Compare June 8, 2022 19:27
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you combined this into a single action.

@david-waltermire david-waltermire merged commit 27b0bba into usnistgov:main Jun 13, 2022
aj-stein-nist added a commit that referenced this pull request Jul 5, 2022
OK, we aren't done yet. First, we started with #1303 to resolve #1302. AJ thought he "fixed it" with c09ec10 then Dave rightfully noticed he had only fixed the board removal job, not creation when adding it in c09ec10. Subsequently, AJ realized that the necessary column should be "Needs Triage" and not "To do" from his test repo. So, we will make sure we fix up the last copy-paste error once and for all.
david-waltermire pushed a commit that referenced this pull request Jul 5, 2022
OK, we aren't done yet. First, we started with #1303 to resolve #1302. AJ thought he "fixed it" with c09ec10 then Dave rightfully noticed he had only fixed the board removal job, not creation when adding it in c09ec10. Subsequently, AJ realized that the necessary column should be "Needs Triage" and not "To do" from his test repo. So, we will make sure we fix up the last copy-paste error once and for all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Issues around enhancing and optimizing work for development of NIST OSCAL artifacts enhancement Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants