Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Parameter Insert Data Type Docs #1112

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Clarify Parameter Insert Data Type Docs #1112

merged 1 commit into from
Jan 26, 2022

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 26, 2022 •
edited
Loading

Committer Notes

Closes #1037.

Updated local build with copy and formatting improvements:

image

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist changed the base branch from main to release-1.0 January 26, 2022 21:35
@aj-stein-nist aj-stein-nist marked this pull request as ready for review January 26, 2022 21:55
@aj-stein-nist aj-stein-nist self-assigned this Jan 26, 2022
@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.1 milestone Jan 26, 2022
@aj-stein-nist aj-stein-nist force-pushed the issue-1037-bug-fix-markup-data-types-parameter branch from 76153ee to 033a441 Compare January 26, 2022 22:04
david-waltermire
david-waltermire approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@david-waltermire david-waltermire merged commit f610a1b into release-1.0 Jan 26, 2022
@david-waltermire david-waltermire deleted the issue-1037-bug-fix-markup-data-types-parameter branch January 26, 2022 22:07
@david-waltermire david-waltermire removed this from the OSCAL 1.0.1 milestone Jan 30, 2022
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@aj-stein-nist @iMichaela
Clarify data types docs for param insert. Closes usnistgov#1037. (usn…
f3b5e24 
…istgov#1112)
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@aj-stein-nist @Rene2mt
Clarify data types docs for param insert. Closes usnistgov#1037. (usn…
23b57f6 
…istgov#1112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees

@aj-stein-nist aj-stein-nist

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown documentation glitch in datatypes page
2 participants
@aj-stein-nist @david-waltermire