Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issue #2

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix security issue #2

merged 1 commit into from
Jun 11, 2019

Conversation

niklas-r
Copy link
Contributor

Why?

As an open source code supplier,
I don't want a big security issue banner on my repo
So that people dare to download and run my code

What?

js-yaml, which is a dependency to ESLint, has some security issues in older versions.

Picture

Screenshot 2019-06-11 at 11 05 54

js-yaml, which is a dependency to ESLint, has some security issues in older versions.
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.12.2.tgz#ef1d067c5a9d9cb65bd72f285b5d8105c77f14fc"
integrity sha512-QHn/Lh/7HhZ/Twc7vJYQTkjuCa0kaCcDcjK5Zlk2rvnUpy7DxMJ23+Jc2dcyvltwQVg1nygAVlB2oRDFHoRS5Q==
js-yaml@^3.13.0:
version "3.13.1"
Copy link
Contributor Author

@niklas-r niklas-r Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the new fixed version which is fixing the issue

Copy link
Contributor

@archive archive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure magic! Good find and initiative!

🍰 and 🍪

@niklas-r niklas-r merged commit 67cb03b into master Jun 11, 2019
@niklas-r niklas-r deleted the update-eslint branch June 11, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants