Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22722 Fix broken link to faq in docs/userguide/icu/index.md #3006

Merged
merged 1 commit into from
May 17, 2024

Conversation

aszasz
Copy link
Contributor

@aszasz aszasz commented May 13, 2024

Checklist
  • [v] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22722
  • [v] Required: The PR title must be prefixed with a JIRA Issue number.
  • [v] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [v] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [v] Issue accepted (done by Technical Committee after discussion)
  • [v] Tests included, if applicable
  • [v] API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We just need the commit message to be amended so that it begins with "ICU-22722 ". The whitespace in between the ticket number and commit message is also important. If you want the commit message to be the same as the PR title, that works.

The easiest way to fix the commit message is to click the "Details" button next to the jira-ticket CI check, click the "Squash" button (even though you're not changing the contents), and then use the opportunity to reword the commit message.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@echeran echeran merged commit 0ef4da9 into unicode-org:main May 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants