Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters of Pivoted Cholesky undocumented and/or unintuitive #164

Open
marcelluethi opened this issue Sep 16, 2016 · 0 comments
Open

Parameters of Pivoted Cholesky undocumented and/or unintuitive #164

marcelluethi opened this issue Sep 16, 2016 · 0 comments
Assignees
@thogerig
Labels
enhancement

Comments

@marcelluethi
Copy link
Contributor

The function

PivotedCholesky.computeApproximateEigGeneric

takes a parameter D. It is from the outside not clear what this parameter does and why
it is needed. Either it has to be documented, or (if possible) hidden from the interface.
thogerig added a commit to thogerig/scalismo that referenced this issue Aug 14, 2019
@thogerig
Removed exposure of mass matrix parameter D, which is in this case a …
607a461 
…scalar (1.0) without a need to be changed. Relates to issue unibas-gravis#164.
@thogerig thogerig mentioned this issue Aug 14, 2019
Merged
marcelluethi pushed a commit that referenced this issue Aug 19, 2019
@thogerig @marcelluethi
Removed exposure of mass matrix parameter D, which is in this case a …
98b9995 
…scalar (1.0) without a need to be changed. Relates to issue #164. (#287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thogerig thogerig

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelluethi @thogerig