Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom sheet with text input style option enabled #248

Merged

Conversation

rohitbhoite
Copy link
Contributor

@rohitbhoite rohitbhoite commented Oct 22, 2023

📜 Description

Added option to enable users to provide custom text input styles.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@rohitbhoite rohitbhoite force-pushed the bottom-sheet-with-text-input-style-option branch from 221b4c5 to d0325e6 Compare October 23, 2023 15:26
@rohitbhoite rohitbhoite force-pushed the bottom-sheet-with-text-input-style-option branch from d0325e6 to 34f013a Compare October 25, 2023 17:33
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bde416) 83.70% compared to head (34f013a) 83.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   83.70%   83.72%   +0.02%     
==========================================
  Files          20       20              
  Lines         632      633       +1     
==========================================
+ Hits          529      530       +1     
  Misses        103      103              
Files Coverage Δ
...back/lib/src/feedback_builder/string_feedback.dart 100.00% <100.00%> (ø)
feedback/lib/src/theme/feedback_theme.dart 86.36% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ueman ueman merged commit 465e572 into ueman:master Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants