Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default darkmode theme #38

Closed
ueman opened this issue Feb 7, 2021 · 2 comments · Fixed by #241
Closed

Create a default darkmode theme #38

ueman opened this issue Feb 7, 2021 · 2 comments · Fixed by #241
Labels

Comments

@ueman
Copy link
Owner

ueman commented Feb 7, 2021

This library currently needs the user to implement a darkmode theme himself.
The library should handle it itself and also change it depending on the OS

@ueman ueman added enhancement New feature or request up-for-grabs labels Feb 7, 2021
@apomalyn
Copy link
Contributor

Do you mind if I take this one for Hacktoberfest? 😄

@ueman
Copy link
Owner Author

ueman commented Sep 26, 2023

No, not at all. Feel free to work on it. Please be aware though, that I'm on vacation for the first half of October, so I may not be able to review it in time.

@apomalyn apomalyn mentioned this issue Oct 3, 2023
5 tasks
ueman pushed a commit that referenced this issue Oct 20, 2023
* feat: Implement a dark theme option

* test(dark-mode): Update goldens and add one test for dark mode

* docs(dark-mode): Improve documentation on the BetterFeedback widget about the theme

* feat(dark-mode): Remove unnecessary call to `FeedbackTheme.of(context)` as we already have it loaded on the build function

* feat(dark-mode): Change color of the drag handle depending on the theme

* test(dark-mode): Update dark mode golden on OSX

* chore(dark-mode): Apply format

* feat(dark-mode): Add the default dark theme on the example so the users can see that it exists

* chore(dark-mode): Remove unused imports

* docs(dark-mode): Improve documentation

* feat(dark-mode): Add dragHandleColor into the theme to improve customization

* feat(dark-mode): Implement light version of the FeedbackThemeData for consistency

* feat(dark-mode): Add color scheme inside the theme to improve customization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants