This repository has been archived by the owner on Feb 24, 2022. It is now read-only.
Fix inverted arguments in Titanic_Survival_Exploration.ipynb #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Titanic_Survival_Exploration.ipynb, accuracy_score() expects the arguments 'truth, pred', but while calling the same function we have inverted the arguments. Although this still works, its confusing and incorrect.
|
Thanks for pointing out, @KarthikNayak! @ShengKungYi Can you confirm (and merge the PR)? |
|
Sorry for the delay in the verification of the change. Shouldn't change anything with the outputs, but it does maintain the consistency of the code. Thanks! |
|
Is this made live in the classroom, as well? |
|
That's a good point. The archive needs to be updated as well. I'll take care of that. |
sthalles
added a commit
to sthalles/machine-learning
that referenced
this pull request
Jun 9, 2016
nelsonvega
added a commit
to nelsonvega/machine-learning
that referenced
this pull request
Nov 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Titanic_Survival_Exploration.ipynb, accuracy_score() expects the arguments
'truth, pred', but while calling the same function we have inverted the arguments.
Although this still works, its confusing and incorrect.