Make OpenJPEGConfig.cmake relocatable with CMake > 3.0 #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using CMakePackageConfigHelpers, we can generate a relocatable OpenJPEGConfig.config, using the PATH_VARS feature to make CMAKE_INSTALL_LIBDIR relative to the installed location. This change is needed for me when cross-compiling since CMAKE_INSTALL_FULL_LIBDIR is a path inside the sysroot rather than an absolute path to the actual includes. Without this change poppler ends up passing a -I flag that does not exist. This includes fallback code for CMake 2.8, which adds a bit of complexity, since I'm not sure if raising the minimum to 3.0 (now over 8 years old) is acceptable.
arichardson
force-pushed
the
relocatable-cmake-config
branch
from
68d6f64
to
c6ceb84
Compare
arichardson
changed the title
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CMakePackageConfigHelpers, we can generate a relocatable
OpenJPEGConfig.config, using the PATH_VARS feature to make
CMAKE_INSTALL_LIBDIR relative to the installed location.
This change is needed for me when cross-compiling since
CMAKE_INSTALL_FULL_LIBDIR is a path inside the sysroot rather than
an absolute path to the actual includes. Without this change poppler
ends up passing a -I flag that does not exist.
This includes fallback code for CMake 2.8, which adds a bit of complexity,
since I'm not sure if raising the minimum to 3.0 (now over 8 years old)
is acceptable.