Add Interval support #202
Merged
Add Interval support #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived IntervalTypeClass from FixedPointTypeClass - DspRealTypeClass needs asInterval - FixedPoint, SInt and UInt type classes needs asInterval - ChiselConvertableFrom get asInterval prototypes - ImplicitsTop gets Interval references - Fixed problem with poking negative fixed point and intervals into verilator backend
chick
changed the title
|
Tests working for this PR requires merge of PR #203 |
|
Dependent instead of PR #185 |
grebe
approved these changes
Apr 8, 2020
src/main/scala/dsptools/numbers/chisel_types/FixedPointTypeClass.scala
Outdated
Show resolved
Hide resolved
| // Note: The above doesn't rely on tools to expand, shrink correctly; the version below does. | ||
| // Assumes setBinaryPoint zero-extends. BUT Chisel doesn't seem to get widths properly and | ||
| // some other ops rely on width correctness... (even though Firrtl is right...) | ||
| //a.setBinaryPoint(newBP) >> n |
There was a problem hiding this comment.
this is unfortunate. do you think our goal should be to ultimately make setBinaryPoint work?
- fixed maskeValue typo - cleaned up big ugly import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived IntervalTypeClass from FixedPointTypeClass